Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 1176053002: Fix cross size of flex items in stocks app (more tests incoming) (Closed)

Created:
5 years, 6 months ago by jackson
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix cross size of flex items in stocks app (more tests incoming) R=abarth@chromium.org, abarth Committed: https://chromium.googlesource.com/external/mojo/+/547054b5ca93189af11a1a3a962c61cdc324473d

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : moar rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -13 lines) Patch
M sky/sdk/lib/framework/rendering/flex.dart View 4 chunks +20 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jackson
5 years, 6 months ago (2015-06-10 19:30:31 UTC) #1
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-10 19:32:05 UTC) #2
jackson
5 years, 6 months ago (2015-06-10 19:54:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
547054b5ca93189af11a1a3a962c61cdc324473d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698