Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 1176043002: Make DocumentModeTest less flaky (Closed)

Created:
5 years, 6 months ago by gone
Modified:
5 years, 6 months ago
Reviewers:
Maria
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make DocumentModeTest less flaky Android likes to hold onto Activities while Chrome is in the foreground. Send the user home before closing everything. BUG=451453 Committed: https://crrev.com/984f779607cc0ca56de0326dcf0f9ee86c8486ef Cr-Commit-Position: refs/heads/master@{#333792}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/test/android/javatests_staging/src/org/chromium/chrome/test/MultiActivityTestBase.java View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
gone
Saw the Incognito launching test acting up locally. Saw that the MultiActivityTestBase was failing to ...
5 years, 6 months ago (2015-06-10 18:45:46 UTC) #2
Maria
lgtm
5 years, 6 months ago (2015-06-10 20:09:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1176043002/1
5 years, 6 months ago (2015-06-10 20:11:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 20:37:37 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 20:38:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/984f779607cc0ca56de0326dcf0f9ee86c8486ef
Cr-Commit-Position: refs/heads/master@{#333792}

Powered by Google App Engine
This is Rietveld 408576698