Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Unified Diff: Source/core/dom/Document.h

Issue 1176013002: Move attributes and methods from HTMLDocument to Document (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Switch importLoader check Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/custom/custom.gypi ('k') | Source/core/dom/Document.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Document.h
diff --git a/Source/core/dom/Document.h b/Source/core/dom/Document.h
index f38e4d3abcfe6fe70d2a00464e62b0aa09b4232d..c096d919f7755ff4e9a3b306a7023712529f63d0 100644
--- a/Source/core/dom/Document.h
+++ b/Source/core/dom/Document.h
@@ -490,11 +490,16 @@ public:
DocumentLoader* loader() const;
- void open(Document* ownerDocument = nullptr, ExceptionState& = ASSERT_NO_EXCEPTION);
+ // This is used internally and does not handle exceptions.
+ void open();
+ // open() is the DOM API document.open()
philipj_slow 2015/06/27 21:49:24 Maybe "This is ..." and the same change for close(
Habib Virji 2015/06/29 12:17:42 Done.
+ void open(Document* ownerDocument, ExceptionState& = ASSERT_NO_EXCEPTION);
philipj_slow 2015/06/27 21:49:24 It doesn't look like this is ever called with just
Habib Virji 2015/06/29 12:17:42 It was actually but I have removed from here and a
PassRefPtrWillBeRawPtr<DocumentParser> implicitOpen(ParserSynchronizationPolicy);
+ // This is used internally and does not handle exceptions.
+ void close();
// close() is the DOM API document.close()
- void close(ExceptionState& = ASSERT_NO_EXCEPTION);
+ void close(ExceptionState&);
// In some situations (see the code), we ignore document.close().
// explicitClose() bypass these checks and actually tries to close the
// input stream.
@@ -518,6 +523,8 @@ public:
void write(const SegmentedString& text, Document* ownerDocument = nullptr, ExceptionState& = ASSERT_NO_EXCEPTION);
void write(const String& text, Document* ownerDocument = nullptr, ExceptionState& = ASSERT_NO_EXCEPTION);
void writeln(const String& text, Document* ownerDocument = nullptr, ExceptionState& = ASSERT_NO_EXCEPTION);
+ void write(LocalDOMWindow*, const Vector<String>& text, ExceptionState& = ASSERT_NO_EXCEPTION);
+ void writeln(LocalDOMWindow*, const Vector<String>& text, ExceptionState& = ASSERT_NO_EXCEPTION);
bool wellFormed() const { return m_wellFormed; }
« no previous file with comments | « Source/bindings/core/v8/custom/custom.gypi ('k') | Source/core/dom/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698