Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7172)

Unified Diff: chromecast/crash/android/cast_crash_reporter_client_android.cc

Issue 1176003005: Chromecast: Android crash startup can't read path from /data/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: privileged flag --> process_type Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/crash/android/cast_crash_reporter_client_android.cc
diff --git a/chromecast/crash/android/cast_crash_reporter_client_android.cc b/chromecast/crash/android/cast_crash_reporter_client_android.cc
index d914767e8501f8bd13c02325218f198b1aec24cf..6e690dd80e32feef70aec0c7a5be8e4648ff2d98 100644
--- a/chromecast/crash/android/cast_crash_reporter_client_android.cc
+++ b/chromecast/crash/android/cast_crash_reporter_client_android.cc
@@ -16,7 +16,9 @@
namespace chromecast {
-CastCrashReporterClientAndroid::CastCrashReporterClientAndroid() {
+CastCrashReporterClientAndroid::CastCrashReporterClientAndroid(
+ const std::string& process_type)
+ : process_type_(process_type) {
}
CastCrashReporterClientAndroid::~CastCrashReporterClientAndroid() {
@@ -45,9 +47,12 @@ bool CastCrashReporterClientAndroid::GetCrashDumpLocation(
}
crash_dir_local = crash_dir_local.Append("crashes");
- if (!base::DirectoryExists(crash_dir_local)) {
- if (!base::CreateDirectory(crash_dir_local)) {
- return false;
+ // Only try to create the directory in the browser process (empty value).
+ if (process_type_.empty()) {
+ if (!base::DirectoryExists(crash_dir_local)) {
+ if (!base::CreateDirectory(crash_dir_local)) {
+ return false;
+ }
}
}
« no previous file with comments | « chromecast/crash/android/cast_crash_reporter_client_android.h ('k') | chromecast/crash/android/crash_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698