Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1945)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart

Issue 1175973005: dart2js cps: Introduce some built-in operators in type propagation. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Improve propagation heuristic Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart
index ff7dea70f46d259f1cc1b1930c617b29c8e61507..5e3b82bdf976108879287ad066b61278f408caf9 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart
@@ -324,8 +324,8 @@ class SExpressionStringifier extends Indentation implements Visitor<String> {
}
String visitTypeExpression(TypeExpression node) {
- String args = node.arguments.map(access).join(', ');
- return '(TypeExpression ${node.dartType.toString()} $args)';
+ String args = node.arguments.map(access).join(' ');
+ return '(TypeExpression ${node.dartType.toString()} ($args))';
Kevin Millikin (Google) 2015/06/12 12:19:10 Since you're changing it, get rid of toString()?
asgerf 2015/06/15 09:26:18 Done.
}
String visitNonTailThrow(NonTailThrow node) {
@@ -335,8 +335,14 @@ class SExpressionStringifier extends Indentation implements Visitor<String> {
String visitCreateInvocationMirror(CreateInvocationMirror node) {
String selector = node.selector.name;
- String args = node.arguments.map(access).join(', ');
- return '(CreateInvocationMirror $selector $args)';
+ String args = node.arguments.map(access).join(' ');
+ return '(CreateInvocationMirror $selector ($args))';
+ }
+
+ String visitApplyBuiltinOperator(ApplyBuiltinOperator node) {
+ String operator = node.operator.toString();
+ String args = node.arguments.map(access).join(' ');
+ return '(ApplyBuiltinOperator $operator ($args))';
}
}

Powered by Google App Engine
This is Rietveld 408576698