Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 1175953003: Revert "Remove obsolete float-management code from line layout" (Closed)

Created:
4 years, 10 months ago by rhogan
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert "Remove obsolete float-management code from line layout" This reverts commit 52100348948ad90e4bce5256383fbe19eca64554. Reason for revert: caused issues with layout identified in crbug.com/498664. BUG=498664, 487775 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196896

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -9 lines) Patch
M Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/LayoutBlockFlowLine.cpp View 4 chunks +19 lines, -1 line 0 comments Download
M Source/core/layout/line/LineLayoutState.h View 3 chunks +5 lines, -0 lines 0 comments Download
A + Source/core/layout/line/TrailingFloatsRootInlineBox.h View 1 chunk +15 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175953003/1
4 years, 10 months ago (2015-06-10 18:40:04 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
4 years, 10 months ago (2015-06-10 18:40:07 UTC) #4
rhogan
4 years, 10 months ago (2015-06-10 18:40:23 UTC) #6
mstensho (USE GERRIT)
lgtm
4 years, 10 months ago (2015-06-10 20:05:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175953003/1
4 years, 10 months ago (2015-06-10 20:06:12 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2015-06-10 20:10:43 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196896

Powered by Google App Engine
This is Rietveld 408576698