Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(13)

Issue 1175913002: Refactoring: Add StyledMarkupAccumulator::createInlineStyle from appendElement (Closed)

Created:
4 years, 10 months ago by hajimehoshi
Modified:
4 years, 10 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-style_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Refactoring: Add StyledMarkupAccumulator::createInlineStyle from appendElement This CL creates StyledMarkupAccumulator::createInlineStyle from appendElement to improve code readability. This CL is a split of crrev.com/1163673005 and I aim to remove enum StyledMarkupAccumulator::RangeFullySelectsNodes. BUG=n/a TEST=n/a; no behavior change Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196850

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -30 lines) Patch
M Source/core/editing/StyledMarkupAccumulator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/editing/StyledMarkupAccumulator.cpp View 2 chunks +37 lines, -30 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
hajimehoshi
4 years, 10 months ago (2015-06-10 08:23:52 UTC) #2
hajimehoshi
PTAL
4 years, 10 months ago (2015-06-10 08:24:00 UTC) #3
yosin_UTC9
Please describe reasons why you move code to new function |createInlineStyle()|, e.g. to improve readability, ...
4 years, 10 months ago (2015-06-10 08:28:49 UTC) #4
hajimehoshi
On 2015/06/10 08:28:49, Yosi_UTC9 wrote: > Please describe reasons why you move code to new ...
4 years, 10 months ago (2015-06-10 08:31:19 UTC) #5
yosin_UTC9
lgtm
4 years, 10 months ago (2015-06-10 08:36:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175913002/1
4 years, 10 months ago (2015-06-10 08:36:24 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2015-06-10 09:49:35 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196850

Powered by Google App Engine
This is Rietveld 408576698