[Android WebView] Implement WebSettings.{get|set}UseWideViewport

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/bind.h"
@@ skipping 3199 matching lines @@
 void RenderViewImpl::ProcessViewLayoutFlags(const CommandLine& command_line) {
   bool enable_viewport =
       command_line.HasSwitch(switches::kEnableViewport);
   bool enable_fixed_layout =
       command_line.HasSwitch(switches::kEnableFixedLayout);
 
   webview()->enableFixedLayoutMode(enable_fixed_layout || enable_viewport);
   webview()->settings()->setFixedElementsLayoutRelativeToFrame(true);
 
   if (enable_viewport) {
+    webkit_preferences_.viewport_enabled = true;

[darin (slow to review), 2013/01/08 17:10:42]

It seems a little odd to be setting a WebPreferences member here in the
RenderViewImpl.  Normally, we initialize WebPreferences in the browser-side, and
then send those all down together when initializing a RenderViewImpl.  Maybe
this change suggests that we shouldn't be checking kEnableViewport in the
renderer, but instead checking that in the browser?

[mnaganov (inactive), 2013/01/08 18:14:44]

Yes, it does look odd to me as well. But as you can see, 'setViewportEnabled'
works together with other settings and even flags that are set directly on a
WebView (enableFixedLayoutMode, setFixedLayoutSize), so we will need to put more
things into WebPreferences and perhaps, move fixed layout parameters into
WebSettings. I can do that first, prior to this patch. 

     webview()->settings()->setViewportEnabled(true);
   } else if (enable_fixed_layout) {
     std::string str =
         command_line.GetSwitchValueASCII(switches::kEnableFixedLayout);
     std::vector<std::string> tokens;
     base::SplitString(str, ',', &tokens);
     if (tokens.size() == 2) {
       int width, height;
       if (base::StringToInt(tokens[0], &width) &&
           base::StringToInt(tokens[1], &height))
@@ skipping 3276 matching lines @@
 }
 #endif
 
 void RenderViewImpl::OnReleaseDisambiguationPopupDIB(
     TransportDIB::Handle dib_handle) {
   TransportDIB* dib = TransportDIB::CreateWithHandle(dib_handle);
   RenderProcess::current()->ReleaseTransportDIB(dib);
 }
 
 }  // namespace content