Issue 11759021: Block the autohide of the launcher when 'quiet mode' bubble is shown for notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11759021: Block the autohide of the launcher when 'quiet mode' bubble is shown for notifications. (Closed)

Created:
7 years, 11 months ago by Jun Mukai

Modified:
7 years, 11 months ago

Reviewers:
stevenjb, sadrul, jennyz

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Block the autohide of the launcher when 'quiet mode' bubble is shown for notifications. BUG=168294 TEST=see the repro steps and the expected behavior in the bug. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175627

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -1 line)			Patch
M	ash/system/status_area_widget.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/system/web_notification/web_notification_tray.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ash/system/web_notification/web_notification_tray.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

jennyz

LGTM. Can you add stevenjb to review the cl, he is the owner of web ...

7 years, 11 months ago (2013-01-04 22:00:11 UTC) #2

commit-bot: I haz the power

7 years, 11 months ago (2013-01-08 00:00:28 UTC) #5

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/11759021/1