Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 11759021: Block the autohide of the launcher when 'quiet mode' bubble is shown for notifications. (Closed)

Created:
7 years, 11 months ago by Jun Mukai
Modified:
7 years, 11 months ago
Reviewers:
stevenjb, sadrul, jennyz
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Block the autohide of the launcher when 'quiet mode' bubble is shown for notifications. BUG=168294 TEST=see the repro steps and the expected behavior in the bug. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175627

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M ash/system/status_area_widget.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/web_notification/web_notification_tray.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jun Mukai
7 years, 11 months ago (2013-01-04 03:54:22 UTC) #1
jennyz
LGTM. Can you add stevenjb to review the cl, he is the owner of web ...
7 years, 11 months ago (2013-01-04 22:00:11 UTC) #2
Jun Mukai
7 years, 11 months ago (2013-01-04 22:02:50 UTC) #3
stevenjb
lgtm
7 years, 11 months ago (2013-01-07 23:57:32 UTC) #4
commit-bot: I haz the power
7 years, 11 months ago (2013-01-08 00:00:28 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698