Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Issue 11759020: Implement a TODO in the media code: Change a "const MediaStreamRequest*" arg in various APIs to "co… (Closed)

Created:
7 years, 11 months ago by Peter Kasting
Modified:
7 years, 11 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, feature-media-reviews_chromium.org, tfarina, jeremya+watch_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Implement a TODO in the media code: Change a "const MediaStreamRequest*" arg in various APIs to "const MediaStreamRequest&". BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175385

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -34 lines) Patch
M chrome/browser/chromeos/login/webui_login_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/media/media_stream_devices_controller.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/media/media_stream_devices_controller.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/extensions/shell_window.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/extensions/shell_window.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/external_tab_container_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/external_tab_container_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/request_media_access_permission_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/request_media_access_permission_helper.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_ui_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_contents_delegate.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Peter Kasting
7 years, 11 months ago (2013-01-04 01:20:32 UTC) #1
no longer working on chromium
On 2013/01/04 01:20:32, Peter Kasting wrote: Sorry for the delay, I am technically on vacation ...
7 years, 11 months ago (2013-01-04 16:12:20 UTC) #2
Peter Kasting
John, can you OWNERS-stamp this?
7 years, 11 months ago (2013-01-05 02:06:47 UTC) #3
jam
7 years, 11 months ago (2013-01-07 20:12:45 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698