Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 1175843002: [chromecast] Disable WebM, Vorbis tests for ALSA (Closed)

Created:
5 years, 6 months ago by cleichner
Modified:
5 years, 6 months ago
Reviewers:
servolk, erickung1, gunsch
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromecast] Disable WebM, Vorbis tests for ALSA The ALSA-based CMA backend doesn't support that functionality yet. BUG=internal b/19544200 Committed: https://crrev.com/0a6df1b01464cee3b8785eb0e3126091108291b3 Cr-Commit-Position: refs/heads/master@{#333766}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chromecast/chromecast_tests.gypi View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
cleichner
5 years, 6 months ago (2015-06-10 01:06:13 UTC) #2
gunsch
https://codereview.chromium.org/1175843002/diff/1/chromecast/chromecast_tests.gypi File chromecast/chromecast_tests.gypi (right): https://codereview.chromium.org/1175843002/diff/1/chromecast/chromecast_tests.gypi#newcode116 chromecast/chromecast_tests.gypi:116: 'cast_shell_browser_test', Are you also disabling cast_shell_browser_test? That shouldn't be ...
5 years, 6 months ago (2015-06-10 16:25:20 UTC) #3
cleichner
PTAL https://codereview.chromium.org/1175843002/diff/1/chromecast/chromecast_tests.gypi File chromecast/chromecast_tests.gypi (right): https://codereview.chromium.org/1175843002/diff/1/chromecast/chromecast_tests.gypi#newcode116 chromecast/chromecast_tests.gypi:116: 'cast_shell_browser_test', On 2015/06/10 16:25:20, gunsch wrote: > Are ...
5 years, 6 months ago (2015-06-10 18:00:35 UTC) #4
gunsch
lgtm
5 years, 6 months ago (2015-06-10 18:03:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175843002/20001
5 years, 6 months ago (2015-06-10 18:09:05 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-10 18:35:20 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 18:36:36 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0a6df1b01464cee3b8785eb0e3126091108291b3
Cr-Commit-Position: refs/heads/master@{#333766}

Powered by Google App Engine
This is Rietveld 408576698