Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1282)

Unified Diff: tools/bench_pictures_main.cpp

Issue 117583002: Update bench pictures to time image decode & upload costs (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: More clean up Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/gpu/GrContext.cpp ('K') | « tools/PictureRenderer.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bench_pictures_main.cpp
===================================================================
--- tools/bench_pictures_main.cpp (revision 12709)
+++ tools/bench_pictures_main.cpp (working copy)
@@ -41,6 +41,8 @@
DEFINE_int32(repeat, 1, "Set the number of times to repeat each test.");
DEFINE_bool(timeIndividualTiles, false, "Report times for drawing individual tiles, rather than "
"times for drawing the whole page. Requires tiled rendering.");
+DEFINE_bool(purgeDecodedTex, false, "Purge decoded textures after each iteration "
+ "(only makes sense with --deferImageDecoding).");
bsalomon 2013/12/18 14:51:36 I don't totally follow why this only makes sense w
robertphillips 2013/12/18 15:59:13 Done. You're right, if we allow it anytime we can
DEFINE_string(timers, "c", "[wcgWC]*: Display wall, cpu, gpu, truncated wall or truncated cpu time"
" for each picture.");
DEFINE_bool(trackDeferredCaching, false, "Only meaningful with --deferImageDecoding and "
@@ -338,6 +340,16 @@
benchmark->setTimeIndividualTiles(true);
}
+ if (FLAGS_purgeDecodedTex) {
+ if (!FLAGS_deferImageDecoding) {
+ gLogger.logError("--purgeDecodedTex doesn't make sense "
+ "without --deferImageDecoding.\n");
+ exit(-1);
+ }
+
+ benchmark->setPurgeDecodedTex(true);
+ }
+
if (FLAGS_readPath.count() < 1) {
gLogger.logError(".skp files or directories are required.\n");
exit(-1);
« src/gpu/GrContext.cpp ('K') | « tools/PictureRenderer.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698