content/child/service_worker/service_worker_dispatcher.h - Issue 1175823002: ServiceWorker: Implement ServiceWorkerRegistration.update() (2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/service_worker_dispatcher.h

Issue 1175823002: ServiceWorker: Implement ServiceWorkerRegistration.update() (2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: trivial fix Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_dispatcher_host.cc ('K') | « content/browser/service_worker/service_worker_dispatcher_host.cc ('k') | content/child/service_worker/service_worker_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/service_worker/service_worker_dispatcher.h

diff --git a/content/child/service_worker/service_worker_dispatcher.h b/content/child/service_worker/service_worker_dispatcher.h

index 28b9f4f98677b0094ab07abfcd9bcd53f32c5629..ad1f9188454cb37136721570bdb6052985010aa0 100644

--- a/content/child/service_worker/service_worker_dispatcher.h

+++ b/content/child/service_worker/service_worker_dispatcher.h

@@ -68,7 +68,11 @@ class CONTENT_EXPORT ServiceWorkerDispatcher

const GURL& pattern,

const GURL& script_url,

WebServiceWorkerRegistrationCallbacks* callbacks);

- // Corresponds to navigator.serviceWorker.unregister()

+ // Corresponds to ServiceWorkerRegistration.update()

kinuko 2015/06/11 03:50:36 nit: It's not only in your change but it's good to

nhiroki 2015/06/11 05:48:34 Done.

+ void UpdateServiceWorker(

+ int provider_id,

+ int64 registration_id);

+ // Corresponds to ServiceWorkerRegistration.unregister()

void UnregisterServiceWorker(

int provider_id,

const GURL& pattern,