Split out Ash dependency in app info dialog unittests

Split out Ash dependency in app info dialog unittests

The app info dialog doesn't have an ash dependency on Mac, so this needs
to be isolated.

The non-Ash tests have both an Extensions and a Views dependency. The
extension system requires a BrowserThreadBundle (from content), which
was previously provided by AshTestBase. However, ViewsTestBase does not
(and shouldn't) have a content dependency. Instead, it can use the
BrowserThreadBundle provided by TestExtensionEnvironment which has some
other useful things.

Then, to satisfy the Views dependency, we still can't use ViewsTestBase
because it has its own MessageLoop that will fight with the
BrowserThreadBundle. A follow-up will introduce a ScopedViewsTestHelper
to allow the test to run on Mac, but for now just use AshTestBase.

In the AppInfo unittests, make better use of TestExtensionEnvironment to
reuse common code.

BUG=485854, 412234
Committed: https://crrev.com/c7bd3ce802ecdbb5a99bb1e0116d2ccd8e3bf86f
Cr-Commit-Position: refs/heads/master@{#334533}

[tapted, 2015-06-11 03:08:58]

tapted@chromium.org changed reviewers:
+ benwells@chromium.org

[tapted, 2015-06-11 03:09:12]

Patchset #7 (id:120001) has been deleted

[tapted, 2015-06-11 03:09:24]

Patchset #7 (id:140001) has been deleted

[tapted, 2015-06-11 06:22:33]

Patchset #9 (id:200001) has been deleted

[tapted, 2015-06-11 23:52:00]

benwells - please take a look at the stuff under
chrome/browser/../{extensions,apps}

(this turned out to be a bit more of an adventure than I was expecting..)

https://codereview.chromium.org/1175783003/diff/260001/chrome/browser/extensi...
File chrome/browser/extensions/test_extension_environment.h (right):

https://codereview.chromium.org/1175783003/diff/260001/chrome/browser/extensi...
chrome/browser/extensions/test_extension_environment.h:53: explicit
TestExtensionEnvironment(base::MessageLoopForUI* message_loop);
this is so something inheriting from AshTestBase can use the threadbundle it
provides... I'm not sure I like this approach though (may be better just to
refactor the tests currently using the default constructor to have their own
threadbunde [but then it's not clear you "need" one for an extension
environment])

[benwells, 2015-06-15 03:53:16]

Bits i understand lgtm. Maybe its just me but this change seems to be doing a
bunch of unrelated things; consider splitting it up.

[tapted, 2015-06-16 00:29:53]

PTAL

On 2015/06/15 03:53:16, benwells wrote:
> Bits i understand lgtm. Maybe its just me but this change seems to be doing a
> bunch of unrelated things; consider splitting it up.

Done. I can leave the non-ash tests still inheriting from AshTestBase and defer
`ScopedViewsTestHelper`. Can't yet run the test on Mac then, but it makes a
pretty neat line between the places you have OWNERS and the places you don't :)

[benwells, 2015-06-16 01:16:38]

slgtm

[tapted, 2015-06-16 01:41:42]

The CQ bit was checked by tapted@chromium.org

[tapted, 2015-06-16 01:41:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
benwells@chromium.org
Link to the patchset: https://codereview.chromium.org/1175783003/#ps280001
(title: "Split out ScopedViewsTestHelper")

[commit-bot: I haz the power, 2015-06-16 01:43:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1175783003/280001

[commit-bot: I haz the power, 2015-06-16 02:50:51]

Committed patchset #12 (id:280001)

[commit-bot: I haz the power, 2015-06-16 02:52:56]

Patchset 12 (id:??) landed as
https://crrev.com/c7bd3ce802ecdbb5a99bb1e0116d2ccd8e3bf86f
Cr-Commit-Position: refs/heads/master@{#334533}