Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(41)

Issue 1175773002: Remove flaky test "synchronous-create-pattern.html" (Closed)

Created:
4 years, 10 months ago by pdr.
Modified:
4 years, 10 months ago
Reviewers:
ojan
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove flaky test "synchronous-create-pattern.html" This test uses setTimeout and is so flaky that it doesn't provide any useful coverage. We should rewrite this test to avoid setTimeout and to use CSS animations in 35ms-green-flash-at-35ms.svg instead of SVG animations. For now I'm removing this test as it is causing failures, but we should re-add it. TBR=ojan BUG=316730 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196816

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -62 lines) Patch
M LayoutTests/FlakyTests View 1 chunk +0 lines, -12 lines 0 comments Download
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/canvas/resources/35ms-green-flash-at-35ms.svg View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/canvas/synchronous-create-pattern.html View 1 chunk +0 lines, -42 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
pdr.
4 years, 10 months ago (2015-06-09 21:27:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175773002/1
4 years, 10 months ago (2015-06-10 00:56:41 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2015-06-10 02:16:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196816

Powered by Google App Engine
This is Rietveld 408576698