Add LinearBoxGradient and RadialBoxGradient decorations for RenderDecoratedBox.

Add LinearBoxGradient and RadialBoxGradient decorations for RenderDecoratedBox.

R=abarth@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/9dde71facd08ec560fa3faaa023450201e4da6e8

[Matt Perry, 2015-06-09 21:18:52]

mpcomplete@chromium.org changed reviewers:
+ abarth@chromium.org

[Matt Perry, 2015-06-09 21:18:53]

Should I add a sky/test?

[abarth-chromium, 2015-06-09 21:23:27]

On 2015/06/09 at 21:18:53, mpcomplete wrote:
> Should I add a sky/test?

Yeah, I think it would be valuable to add a sky/tests.  It's hard to test the
actual graphical output, but you can test that the Canvas receives the expected
calls.

[abarth-chromium, 2015-06-09 21:23:40]

LGTM w/ test and changes above.

https://codereview.chromium.org/1175763002/diff/20001/sky/examples/raw/shadow...
File sky/examples/raw/shadowed_box.dart (right):

https://codereview.chromium.org/1175763002/diff/20001/sky/examples/raw/shadow...
sky/examples/raw/shadowed_box.dart:17: boxGradient: new RadialBoxGradient(
s/RadialBoxGradient/RadialGradient/  ?

https://codereview.chromium.org/1175763002/diff/20001/sky/sdk/lib/framework/r...
File sky/sdk/lib/framework/rendering/box.dart (right):

https://codereview.chromium.org/1175763002/diff/20001/sky/sdk/lib/framework/r...
sky/sdk/lib/framework/rendering/box.dart:659: String toString();
You can skip this declaration.  It's declared already on dart's root object
type.

https://codereview.chromium.org/1175763002/diff/20001/sky/sdk/lib/framework/r...
sky/sdk/lib/framework/rendering/box.dart:723: final BoxGradient boxGradient;
boxGradient -> gradient

We should probably rename boxShadow to shadow.  I just used that name to be
consistent with CSS.

[Matt Perry, 2015-06-09 21:38:28]

I think I'll have to modify Paint.toString* for a test to be at all useful.
Right now the only output that would change is the Paint's shader (or looper,
for shadows), which doesn't show up in our render tree dump. Ex:

https://github.com/domokit/mojo/blob/1873bd7997e11a335be7e592674892793d13de3d...

* (modifying toString would require exposing getters for Paint's other
properties, and even then we would only see a generic "shader exists" type
message)

https://codereview.chromium.org/1175763002/diff/20001/sky/examples/raw/shadow...
File sky/examples/raw/shadowed_box.dart (right):

https://codereview.chromium.org/1175763002/diff/20001/sky/examples/raw/shadow...
sky/examples/raw/shadowed_box.dart:17: boxGradient: new RadialBoxGradient(
On 2015/06/09 21:23:39, abarth wrote:
> s/RadialBoxGradient/RadialGradient/  ?

Done.

https://codereview.chromium.org/1175763002/diff/20001/sky/sdk/lib/framework/r...
File sky/sdk/lib/framework/rendering/box.dart (right):

https://codereview.chromium.org/1175763002/diff/20001/sky/sdk/lib/framework/r...
sky/sdk/lib/framework/rendering/box.dart:659: String toString();
On 2015/06/09 21:23:39, abarth wrote:
> You can skip this declaration.  It's declared already on dart's root object
> type.

Done.

https://codereview.chromium.org/1175763002/diff/20001/sky/sdk/lib/framework/r...
sky/sdk/lib/framework/rendering/box.dart:723: final BoxGradient boxGradient;
On 2015/06/09 21:23:40, abarth wrote:
> boxGradient -> gradient
> 
> We should probably rename boxShadow to shadow.  I just used that name to be
> consistent with CSS.

Done.

[Matt Perry, 2015-06-09 22:10:35]

Mind if I add the test in a future CL? It's going to require some more changes.

[abarth-chromium, 2015-06-09 22:39:39]

Fine with me.

[Matt Perry, 2015-06-10 16:24:01]

Committed patchset #2 (id:20001) manually as
9dde71facd08ec560fa3faaa023450201e4da6e8 (presubmit successful).