[Cronet] Set up HttpServerPropertiesManager

net/url_request/url_request_context_builder.h

Index: net/url_request/url_request_context_builder.h
diff --git a/net/url_request/url_request_context_builder.h b/net/url_request/url_request_context_builder.h
index a104c4386550a0d43363b6d9f159c48c4866ffb6..73826edd8e46f1cdaa47f20b5056606fe5bb010a 100644
--- a/net/url_request/url_request_context_builder.h
+++ b/net/url_request/url_request_context_builder.h
@@ -22,6 +22,7 @@
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
+#include "base/memory/weak_ptr.h"
 #include "build/build_config.h"
 #include "net/base/net_export.h"
 #include "net/base/network_delegate.h"
@@ -42,6 +43,7 @@ class CookieStore;
 class FtpTransactionFactory;
 class HostMappingRules;
 class HttpAuthHandlerFactory;
+class HttpServerProperties;
 class ProxyConfigService;
 class URLRequestContext;
 class URLRequestInterceptor;
@@ -207,6 +209,12 @@ class NET_EXPORT URLRequestContextBuilder {
   // SdchOwner in net/sdch/sdch_owner.h is a simple policy object.
   void set_sdch_enabled(bool enable) { sdch_enabled_ = enable; }
 
+  // Sets a specific HttpServerPropertiesManager for use in the
+  // URLRequestContext rather than creating a HttpServerPropertiesImpl by
+  // default.
+  void SetHttpServerProperties(
+      base::WeakPtr<HttpServerProperties> http_server_properties);

[mmenke, 2015/07/09 16:18:03]

This should probably take ownership (And then the called can keep a non-owning
pointer).  That's how all the other methods work, except the ones that copy
their data or take ref pointers.

The caller should keep a non-weak pointers (Exposing weak pointers to the
outside world in general is bad, and we shouldn't do that - I've filed a bug
about HttpServerProperties doing that).

[xunjieli, 2015/07/09 17:18:10]

Done. I see. Thanks for the explanation! I didn't realize that caller can keep a
raw pointer.

+
   URLRequestContext* Build();
 
  private:
@@ -248,6 +256,7 @@ class NET_EXPORT URLRequestContextBuilder {
   scoped_ptr<FtpTransactionFactory> ftp_transaction_factory_;
   std::vector<SchemeFactory> extra_http_auth_handlers_;
   ScopedVector<URLRequestInterceptor> url_request_interceptors_;
+  base::WeakPtr<HttpServerProperties> http_server_properties_;
 
   DISALLOW_COPY_AND_ASSIGN(URLRequestContextBuilder);
 };