Make sure the soft-keyboard shows up in the Add Exception dialog.

Make sure the soft-keyboard shows up in the Add Exception dialog.

BUG=472557
Committed: https://crrev.com/b6d7272854375327f011df67a60108820124df91
Cr-Commit-Position: refs/heads/master@{#333615}

[Finnur, 2015-06-09 20:26:50]

finnur@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Finnur, 2015-06-09 20:26:51]

Tried various things, both in code and IME properties in xml, but this was the
only thing that seemed to work reliably.

[Ted C, 2015-06-09 20:46:56]

https://codereview.chromium.org/1175723002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/AddExceptionPreference.java
(right):

https://codereview.chromium.org/1175723002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/AddExceptionPreference.java:104:
showSoftKeyboard(false);
We have methods like this in UiUtils, can we use that instead?

[Finnur, 2015-06-09 22:16:10]

https://codereview.chromium.org/1175723002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/AddExceptionPreference.java
(right):

https://codereview.chromium.org/1175723002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/AddExceptionPreference.java:104:
showSoftKeyboard(false);
Unfortunately, they don't work in this scenario -- specifically calling
UiUtils.showKeyboard(input) instead of line 159 has no effect. :/

[Ted C, 2015-06-09 22:36:19]

https://codereview.chromium.org/1175723002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/AddExceptionPreference.java
(right):

https://codereview.chromium.org/1175723002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/AddExceptionPreference.java:104:
showSoftKeyboard(false);
On 2015/06/09 22:16:09, Finnur wrote:
> Unfortunately, they don't work in this scenario -- specifically calling
> UiUtils.showKeyboard(input) instead of line 159 has no effect. :/

If you were to add a:
http://developer.android.com/reference/android/app/Dialog.html#setOnShowListe...

And call the UiUtils method would it work?

I suspect the issue is the view is not actually in the view hierarchy yet.  I
wonder if you could post a task would it work as well.

[Finnur, 2015-06-09 23:22:51]

https://codereview.chromium.org/1175723002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/AddExceptionPreference.java
(right):

https://codereview.chromium.org/1175723002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/AddExceptionPreference.java:104:
showSoftKeyboard(false);
Excellent suggestion. Done. PTAL.

[Ted C, 2015-06-09 23:25:27]

On 2015/06/09 23:22:51, Finnur wrote:
>
https://codereview.chromium.org/1175723002/diff/1/chrome/android/java/src/org...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/AddExceptionPreference.java
> (right):
> 
>
https://codereview.chromium.org/1175723002/diff/1/chrome/android/java/src/org...
>
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/AddExceptionPreference.java:104:
> showSoftKeyboard(false);
> Excellent suggestion. Done. PTAL.

lgtm

[Finnur, 2015-06-09 23:32:09]

The CQ bit was checked by finnur@chromium.org

[commit-bot: I haz the power, 2015-06-09 23:37:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1175723002/40001

[commit-bot: I haz the power, 2015-06-10 00:01:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-10 00:03:12]

Patchset 3 (id:??) landed as
https://crrev.com/b6d7272854375327f011df67a60108820124df91
Cr-Commit-Position: refs/heads/master@{#333615}