Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(6)

Issue 1175713002: wtf: Add missing operator==(const char*, const AtomicString&). (Closed)

Created:
4 years, 10 months ago by jbroman
Modified:
4 years, 10 months ago
Reviewers:
tkent, Erik Corry
CC:
blink-reviews, blink-reviews-wtf_chromium.org, Mikhail, bemasc
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

wtf: Add missing operator==(const char*, const AtomicString&). Because of this, the following (natural) statement would not compile in tests: ASSERT_EQ("expected", AtomicString("actual")); AtomicStringTest didn't catch this because it had the actual and expected values reversed in each case that used equality. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196807

Patch Set 1 #

Patch Set 2 : AtomicStringTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M Source/wtf/text/AtomicString.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/wtf/text/AtomicStringTest.cpp View 1 1 chunk +11 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jbroman
It looks to me like this was simply an oversight (one that's easy to fix).
4 years, 10 months ago (2015-06-09 21:13:02 UTC) #2
tkent
lgtm
4 years, 10 months ago (2015-06-09 23:51:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175713002/20001
4 years, 10 months ago (2015-06-09 23:51:21 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-09 23:55:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196807

Powered by Google App Engine
This is Rietveld 408576698