Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issue 1175703004: cc: DCHECK if SDOS::SwapBuffersComplete is called prematurely (Closed)

Created:
5 years, 6 months ago by brianderson
Modified:
5 years, 6 months ago
Reviewers:
jbauman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: DCHECK if SDOS::SwapBuffersComplete is called prematurely This is for debugging purposes only and will be reverted soon. BUG=495650 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/5ea9e525a197fb1a55c38db8d1c739771e520fbd Cr-Commit-Position: refs/heads/master@{#333667}

Patch Set 1 #

Total comments: 1

Patch Set 2 : false -> 0' #

Patch Set 3 : stack traces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M cc/scheduler/scheduler.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M cc/surfaces/surface_display_output_surface.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/surfaces/surface_display_output_surface.cc View 1 2 4 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
brianderson
John recommended trying something like this to gather more info while looking at the problem ...
5 years, 6 months ago (2015-06-10 00:12:30 UTC) #2
jbauman
lgtm https://codereview.chromium.org/1175703004/diff/1/cc/surfaces/surface_display_output_surface.cc File cc/surfaces/surface_display_output_surface.cc (right): https://codereview.chromium.org/1175703004/diff/1/cc/surfaces/surface_display_output_surface.cc#newcode25 cc/surfaces/surface_display_output_surface.cc:25: inside_swap_buffers_(false) { 0
5 years, 6 months ago (2015-06-10 00:17:46 UTC) #3
sunnyps
On 2015/06/10 00:12:30, brianderson wrote: > John recommended trying something like this to gather more ...
5 years, 6 months ago (2015-06-10 00:20:37 UTC) #4
brianderson
On 2015/06/10 00:20:37, sunnyps wrote: > On 2015/06/10 00:12:30, brianderson wrote: > > John recommended ...
5 years, 6 months ago (2015-06-10 00:21:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175703004/40001
5 years, 6 months ago (2015-06-10 00:44:23 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-10 03:09:05 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 03:10:06 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5ea9e525a197fb1a55c38db8d1c739771e520fbd
Cr-Commit-Position: refs/heads/master@{#333667}

Powered by Google App Engine
This is Rietveld 408576698