[Android] Conditionally enable M text selection features

[Android] Conditionally enable M text selection features

Enable longpress drag selection and smart selection by default on
Android platforms more recent than L, for both Chrome and WebView.

BUG=466749, 451255
Committed: https://crrev.com/cd8d956ab372ece695ca4aaa48bcf5dd4699b3ba
Cr-Commit-Position: refs/heads/master@{#333781}

[jdduke (slow), 2015-06-10 15:15:21]

jdduke@chromium.org changed reviewers:
+ mfomitchev@chromium.org

[jdduke (slow), 2015-06-10 15:15:22]

Mikhail, any thoughts on landing this now? I know we want to add perf tests
before shipping, but we're probably OK as long as we have that sorted about
before branch. I'll sleep a little better knowing that a nonzero number of users
will start seeing the new behaviors before they ship with the final M release
:).

I also found a few cases where we've gated features on > L MR1, and as these
changes aren't dependent on new APIs, and M has already been announced, I think
we're OK in that respect.

[mfomitchev, 2015-06-10 15:59:45]

mfomitchev@chromium.org changed reviewers:
+ leviw@chromium.org

[mfomitchev, 2015-06-10 16:01:49]

On 2015/06/10 15:15:22, jdduke wrote:
> Mikhail, any thoughts on landing this now? I know we want to add perf tests
> before shipping, but we're probably OK as long as we have that sorted about
> before branch. I'll sleep a little better knowing that a nonzero number of
users
> will start seeing the new behaviors before they ship with the final M release
> :).
> 
> I also found a few cases where we've gated features on > L MR1, and as these
> changes aren't dependent on new APIs, and M has already been announced, I
think
> we're OK in that respect.

+leviw
I think this makes sense: M will won't ship before M46, right? So we should
plenty of time to sort this out, and exposing this to M dogfooders makes sense.
Levi, what do you think?

[leviw_travelin_and_unemployed, 2015-06-10 17:54:57]

On 2015/06/10 at 16:01:49, mfomitchev wrote:
> On 2015/06/10 15:15:22, jdduke wrote:
> > Mikhail, any thoughts on landing this now? I know we want to add perf tests
> > before shipping, but we're probably OK as long as we have that sorted about
> > before branch. I'll sleep a little better knowing that a nonzero number of
users
> > will start seeing the new behaviors before they ship with the final M
release
> > :).
> > 
> > I also found a few cases where we've gated features on > L MR1, and as these
> > changes aren't dependent on new APIs, and M has already been announced, I
think
> > we're OK in that respect.
> 
> +leviw
> I think this makes sense: M will won't ship before M46, right? So we should
plenty of time to sort this out, and exposing this to M dogfooders makes sense.
> Levi, what do you think?

My concern is that we're comfortable with the performance before this is default
behavior on shipping Chrome.

That said, I like the sound of more eyes on this as well (especially
dogfooders), and I don't know much about the M timeline. It sounds reasonable.

[mfomitchev, 2015-06-10 19:27:10]

On 2015/06/10 17:54:57, leviw wrote:
> On 2015/06/10 at 16:01:49, mfomitchev wrote:
> > On 2015/06/10 15:15:22, jdduke wrote:
> > > Mikhail, any thoughts on landing this now? I know we want to add perf
tests
> > > before shipping, but we're probably OK as long as we have that sorted
about
> > > before branch. I'll sleep a little better knowing that a nonzero number of
> users
> > > will start seeing the new behaviors before they ship with the final M
> release
> > > :).
> > > 
> > > I also found a few cases where we've gated features on > L MR1, and as
these
> > > changes aren't dependent on new APIs, and M has already been announced, I
> think
> > > we're OK in that respect.
> > 
> > +leviw
> > I think this makes sense: M will won't ship before M46, right? So we should
> plenty of time to sort this out, and exposing this to M dogfooders makes
sense.
> > Levi, what do you think?
> 
> My concern is that we're comfortable with the performance before this is
default
> behavior on shipping Chrome.
> 
> That said, I like the sound of more eyes on this as well (especially
> dogfooders), and I don't know much about the M timeline. It sounds reasonable.

Cool. LGTM

[jdduke (slow), 2015-06-10 19:42:38]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2015-06-10 19:43:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1175703002/20001

[commit-bot: I haz the power, 2015-06-10 20:10:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-10 20:11:39]

Patchset 2 (id:??) landed as
https://crrev.com/cd8d956ab372ece695ca4aaa48bcf5dd4699b3ba
Cr-Commit-Position: refs/heads/master@{#333781}