Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1175693002: Cleanup GN BUILD files, gni's and imports. (Closed)

Created:
5 years, 6 months ago by msw
Modified:
5 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, Aaron Boodman, viettrungluu+watch_chromium.org, yurys, abarth-chromium, feature-media-reviews_chromium.org, yzshen+watch_chromium.org, devtools-reviews_chromium.org, piman+watch_chromium.org, dcheng, ben+mojo_chromium.org, darin (slow to review), pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup GN BUILD files, gni's and imports. Remove unused mojo/public/mojo_sdk.gni. (we use third_party/mojo's version instead) Update, use mojo/public/ mojo.gni and mojo_application.gni (to define Chromium's mojo_root, mojo_native_application) (we'll need a custom mojo_native_application for 498020) Remove unnecessary imports of related gni files. BUG=498020 TEST=Build still works as expected; no regressions. R=sky@chromium.org TBR=jochen@chromium.org,xhwang@chromium.org Committed: https://crrev.com/4ece34be265cc6205eea813b6805e1659c3131ca Cr-Commit-Position: refs/heads/master@{#333600}

Patch Set 1 #

Patch Set 2 : Revert mojo app layout changes. #

Patch Set 3 : Sync and rebase. #

Patch Set 4 : Restore build/config/ui.gni import for core_services. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -198 lines) Patch
M components/clipboard/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/clipboard/public/interfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/devtools_service/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/devtools_service/public/interfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/filesystem/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/public/interfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/gpu/public/interfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/html_viewer/BUILD.gn View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M components/resource_provider/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/resource_provider/public/cpp/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M components/resource_provider/public/interfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/view_manager/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/gles2/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M components/view_manager/native_viewport/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/view_manager/public/cpp/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/view_manager/public/interfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/view_manager/surfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/surfaces/public/interfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mandoline/app/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M mandoline/app/android/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M mandoline/app/desktop/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M mandoline/services/core_services/BUILD.gn View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M mandoline/services/navigation/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/tab/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M mandoline/ui/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M mandoline/ui/omnibox/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M media/mojo/services/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/application/public/cpp/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/application/public/interfaces/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/gles2/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/mojo_application_package.gni View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/mojo.gni View 1 chunk +8 lines, -1 line 0 comments Download
M mojo/public/mojo_application.gni View 1 5 chunks +19 lines, -2 lines 0 comments Download
D mojo/public/mojo_sdk.gni View 1 chunk +0 lines, -139 lines 0 comments Download
M mojo/runner/BUILD.gn View 1 chunk +2 lines, -4 lines 0 comments Download
M mojo/runner/test/BUILD.gn View 1 chunk +5 lines, -3 lines 0 comments Download
M mojo/services/network/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/public/cpp/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/network/public/interfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/test_service/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/tracing/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/mojo/events/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
msw
Hey Scott, please take a look; thanks!
5 years, 6 months ago (2015-06-09 20:21:39 UTC) #2
sky
LGTM
5 years, 6 months ago (2015-06-09 20:55:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175693002/40001
5 years, 6 months ago (2015-06-09 20:57:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/4620)
5 years, 6 months ago (2015-06-09 21:10:13 UTC) #7
msw
TBR: jochen for components and xhwang for media.
5 years, 6 months ago (2015-06-09 21:53:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175693002/60001
5 years, 6 months ago (2015-06-09 21:58:14 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-09 22:49:52 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 22:50:35 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4ece34be265cc6205eea813b6805e1659c3131ca
Cr-Commit-Position: refs/heads/master@{#333600}

Powered by Google App Engine
This is Rietveld 408576698