Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1175683002: Add a shadow to the FloatingActionButton. (Closed)

Created:
5 years, 6 months ago by Matt Perry
Modified:
5 years, 6 months ago
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add a shadow to the FloatingActionButton. Also added a helper class to Sky framework for building shadow DrawLoopers. R=abarth@chromium.org, eseidel@chromium.org, ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/e2838460b4b21ae743ab5e958d2148087fc389f9

Patch Set 1 #

Total comments: 1

Patch Set 2 : moved to painting/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -17 lines) Patch
M sky/sdk/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/lib/framework/components2/floating_action_button.dart View 1 2 chunks +8 lines, -1 line 0 comments Download
A sky/sdk/lib/framework/painting/shadows.dart View 1 1 chunk +31 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/rendering/box.dart View 1 2 chunks +4 lines, -16 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Matt Perry
5 years, 6 months ago (2015-06-09 18:50:53 UTC) #2
eseidel
lgtm
5 years, 6 months ago (2015-06-09 18:56:55 UTC) #3
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-09 18:56:56 UTC) #5
Hixie
https://codereview.chromium.org/1175683002/diff/1/sky/sdk/lib/framework/rendering/shadows.dart File sky/sdk/lib/framework/rendering/shadows.dart (right): https://codereview.chromium.org/1175683002/diff/1/sky/sdk/lib/framework/rendering/shadows.dart#newcode1 sky/sdk/lib/framework/rendering/shadows.dart:1: // Copyright 2015 The Chromium Authors. All rights reserved. ...
5 years, 6 months ago (2015-06-09 19:06:19 UTC) #7
abarth-chromium
On 2015/06/09 at 19:06:19, ianh wrote: > https://codereview.chromium.org/1175683002/diff/1/sky/sdk/lib/framework/rendering/shadows.dart > File sky/sdk/lib/framework/rendering/shadows.dart (right): > > https://codereview.chromium.org/1175683002/diff/1/sky/sdk/lib/framework/rendering/shadows.dart#newcode1 ...
5 years, 6 months ago (2015-06-09 19:13:54 UTC) #8
Hixie
lgtm
5 years, 6 months ago (2015-06-09 19:26:37 UTC) #9
Matt Perry
I'll move shadows.dart to a painting/ dir before checking this in.
5 years, 6 months ago (2015-06-09 19:46:59 UTC) #10
Matt Perry
5 years, 6 months ago (2015-06-09 19:51:08 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
e2838460b4b21ae743ab5e958d2148087fc389f9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698