Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1175673002: Add android native_app_glue to platform_tools/android/third_party (Closed)

Created:
5 years, 6 months ago by joshua.litt
Modified:
5 years, 6 months ago
Reviewers:
joshualitt, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add android native_app_glue to platform_tools/android/third_party BUG=skia: Committed: https://skia.googlesource.com/skia/+/cf94c74fef53a01a29a34d328d28ff03076dd1b2

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+806 lines, -1 line) Patch
M platform_tools/android/gyp/dependencies.gypi View 1 chunk +16 lines, -0 lines 0 comments Download
A + platform_tools/android/third_party/native_app_glue/README View 1 chunk +1 line, -1 line 1 comment Download
A platform_tools/android/third_party/native_app_glue/android_native_app_glue.h View 1 chunk +349 lines, -0 lines 0 comments Download
A platform_tools/android/third_party/native_app_glue/android_native_app_glue.c View 1 chunk +440 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
joshualitt
ptal
5 years, 6 months ago (2015-06-09 18:30:31 UTC) #2
djsollen
lgtm with one nit https://codereview.chromium.org/1175673002/diff/1/platform_tools/android/third_party/native_app_glue/README File platform_tools/android/third_party/native_app_glue/README (right): https://codereview.chromium.org/1175673002/diff/1/platform_tools/android/third_party/native_app_glue/README#newcode4 platform_tools/android/third_party/native_app_glue/README:4: NDK_REVISION: 10c (October 2014) is ...
5 years, 6 months ago (2015-06-09 19:11:12 UTC) #3
joshualitt
On 2015/06/09 19:11:12, djsollen wrote: > lgtm with one nit > > https://codereview.chromium.org/1175673002/diff/1/platform_tools/android/third_party/native_app_glue/README > File ...
5 years, 6 months ago (2015-06-09 19:23:41 UTC) #4
djsollen
not necessary that revision should work fine.
5 years, 6 months ago (2015-06-09 19:26:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175673002/1
5 years, 6 months ago (2015-06-09 19:27:16 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 19:33:18 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cf94c74fef53a01a29a34d328d28ff03076dd1b2

Powered by Google App Engine
This is Rietveld 408576698