Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(20)

Issue 1175623002: Revert of Moving HitTest function to DeprecatedPaintLayerStackingNode. (Closed)

Created:
4 years, 10 months ago by chadarmstrong
Modified:
4 years, 10 months ago
CC:
aboxhall, blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-rendering, dmazzoni, dshwang, eae+blinkwatch, jchaffraix+rendering, je_julie, leviw+renderwatch, nektarios, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Moving HitTest function to DeprecatedPaintLayerStackingNode. (patchset #4 id:60001 of https://codereview.chromium.org/1158673008/) Reason for revert: We just learned that Slimming Paint will also be modifying the Hit Testing code, and it would therefore be better to leave the code as is for now. Original issue's description: > Moved HitTest function to DeprecatedPaintLayerStackingNode. > > This is the first step of ultimately minimizing the code in DeprecatedPaintLayer, > so that it can be easily removed later. > See > https://docs.google.com/document/d/1YApHVA0hJDWeFGxHPpJ6J5JM5Wcz2h3s24KPSFp8VMg/edit?pli=1#heading=h.j2l17vvztg48. > > BUG=496770 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196690 TBR=jchaffraix@chromium.org,dsinclair@chromium.org,dmazzoni@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=496770 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196788

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -64 lines) Patch
M Source/core/layout/LayoutView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/DeprecatedPaintLayer.h View 3 chunks +7 lines, -4 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayer.cpp View 1 chunk +51 lines, -0 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerStackingNode.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerStackingNode.cpp View 2 chunks +0 lines, -54 lines 0 comments Download
M Source/modules/accessibility/AXLayoutObject.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
chadarmstrong
Created Revert of Moving HitTest function to DeprecatedPaintLayerStackingNode.
4 years, 10 months ago (2015-06-09 16:56:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175623002/1
4 years, 10 months ago (2015-06-09 16:56:26 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
4 years, 10 months ago (2015-06-09 16:56:29 UTC) #4
chrishtr
lgtm
4 years, 10 months ago (2015-06-09 18:15:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175623002/1
4 years, 10 months ago (2015-06-09 18:15:54 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2015-06-09 18:16:32 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196788

Powered by Google App Engine
This is Rietveld 408576698