Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 11756005: Implement rough new dialog style. (Closed)

Created:
7 years, 11 months ago by msw
Modified:
7 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, alicet1, msw+watch_chromium.org, Mike Wittman
Visibility:
Public.

Description

Implement rough new dialog style. Add/update and use NativeTheme dialog colors for Win/Aura. Use Label[Button] and Bubble[Border|Background] in DialogFrameView. Add DialogFrameView::content_margins_ similar to BubbleFrameView. Increase widget example size, add DialogExample with title. Tweak dialog example InitParams (nix frame, make transparent). Make the buttons in the widget example focusable. Make LabelButton::GetPreferredSize public. Refactor BubbleFrameView::GetBoundsForClientView. Roughly matches the specification at: https://docs.google.com/a/google.com/file/d/0B6x6iYCtKinEVjFvOWNfRlJCLU0/edit See the screenshot on the bug at: https://code.google.com/p/chromium/issues/detail?id=166075#c5 TODO(followup): Investigate a minor LabelButton drag/hot issue. TODO(followup): Add/use new close (x) button resources. TODO(followup): Generalize BubbleBorder to a custom frame border? BUG=166075 TEST=[Views examples] dialogs look closer to mocks with --enable-new-dialog-style (actual Chrome dialogs need more work). R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175411

Patch Set 1 #

Patch Set 2 : Refine, use NativeTheme color. #

Patch Set 3 : Fix CrOS build. #

Total comments: 4

Patch Set 4 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -154 lines) Patch
M ash/shell.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/native_theme/native_theme_aura.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M ui/native_theme/native_theme_win.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M ui/views/bubble/bubble_frame_view.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M ui/views/controls/button/label_button.h View 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/controls/button/label_button.cc View 2 chunks +28 lines, -28 lines 0 comments Download
M ui/views/examples/widget_example.cc View 1 4 chunks +18 lines, -2 lines 0 comments Download
M ui/views/window/dialog_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/window/dialog_frame_view.h View 1 2 3 2 chunks +7 lines, -14 lines 0 comments Download
M ui/views/window/dialog_frame_view.cc View 1 2 3 3 chunks +46 lines, -97 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
msw
Hey Scott, please take a look; thanks!
7 years, 11 months ago (2013-01-04 16:31:04 UTC) #1
sky
LGTM https://codereview.chromium.org/11756005/diff/8001/ui/views/window/dialog_frame_view.cc File ui/views/window/dialog_frame_view.cc (right): https://codereview.chromium.org/11756005/diff/8001/ui/views/window/dialog_frame_view.cc#newcode46 ui/views/window/dialog_frame_view.cc:46: title_ = new Label(title, rb.GetFont(ui::ResourceBundle::MediumFont)); Can you member ...
7 years, 11 months ago (2013-01-07 16:51:03 UTC) #2
msw
Done, thanks. Landing. https://codereview.chromium.org/11756005/diff/8001/ui/views/window/dialog_frame_view.cc File ui/views/window/dialog_frame_view.cc (right): https://codereview.chromium.org/11756005/diff/8001/ui/views/window/dialog_frame_view.cc#newcode46 ui/views/window/dialog_frame_view.cc:46: title_ = new Label(title, rb.GetFont(ui::ResourceBundle::MediumFont)); On ...
7 years, 11 months ago (2013-01-07 18:06:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/11756005/17001
7 years, 11 months ago (2013-01-07 18:06:52 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_aura for step(s) interactive_ui_tests
7 years, 11 months ago (2013-01-07 19:51:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/11756005/17001
7 years, 11 months ago (2013-01-07 20:44:43 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_aura for step(s) interactive_ui_tests
7 years, 11 months ago (2013-01-07 23:03:00 UTC) #7
msw
7 years, 11 months ago (2013-01-07 23:06:28 UTC) #8
On 2013/01/07 23:03:00, I haz the power (commit-bot) wrote:
> Retried try job too often on win_aura for step(s) interactive_ui_tests

Others' win_aura builds are failing the same interactive_ui_tests; landing
manually:
http://build.chromium.org/p/tryserver.chromium/builders/win_aura/builds/12850
http://build.chromium.org/p/tryserver.chromium/builders/win_aura/builds/12842
http://build.chromium.org/p/tryserver.chromium/builders/win_aura/builds/12841

Powered by Google App Engine
This is Rietveld 408576698