Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(115)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1175563004: [SP] Save and restore slimming paint enabled state in SP-specific unit tests. (Closed)

Created:
4 years, 10 months ago by wkorman
Modified:
4 years, 10 months ago
Reviewers:
chrishtr, Xianzhu, eae
CC:
blink-reviews, blink-reviews-paint_chromium.org, Rik, danakj, dshwang, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[SP] Save and restore slimming paint enabled state in SP-specific unit tests. BUG=497950 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196810

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -7 lines) Patch
M Source/core/page/PrintContextTest.cpp View 2 chunks +8 lines, -1 line 0 comments Download
M Source/core/paint/DisplayItemListPaintTest.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/paint/LayerClipRecorderTest.cpp View 2 chunks +8 lines, -1 line 0 comments Download
M Source/core/paint/LayoutObjectDrawingRecorderTest.cpp View 2 chunks +5 lines, -2 lines 0 comments Download
M Source/platform/graphics/paint/DisplayItemListTest.cpp View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
wkorman
Aiming to address Xianzhu's comment here: https://code.google.com/p/chromium/issues/detail?id=497950#c11
4 years, 10 months ago (2015-06-09 23:04:00 UTC) #2
Xianzhu
lgtm
4 years, 10 months ago (2015-06-09 23:41:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175563004/1
4 years, 10 months ago (2015-06-09 23:52:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/34974)
4 years, 10 months ago (2015-06-09 23:58:47 UTC) #7
wkorman
4 years, 10 months ago (2015-06-10 00:16:28 UTC) #9
eae
RS LGTM for Source/platform
4 years, 10 months ago (2015-06-10 00:18:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175563004/1
4 years, 10 months ago (2015-06-10 00:19:03 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2015-06-10 01:08:47 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196810

Powered by Google App Engine
This is Rietveld 408576698