Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1293)

Unified Diff: Source/modules/accessibility/AXTableColumn.cpp

Issue 1175533004: Refactor: Clear m_axObjectCache when AXObject detaches (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added ASSERT Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/accessibility/AXTableColumn.h ('k') | Source/modules/accessibility/AXTableHeaderContainer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXTableColumn.cpp
diff --git a/Source/modules/accessibility/AXTableColumn.cpp b/Source/modules/accessibility/AXTableColumn.cpp
index 06fdc764a1040e46115fcf89388b63f5850f2e44..b85c7fe4f6eb78c15628a5906a90d50e8ef9f8ef 100644
--- a/Source/modules/accessibility/AXTableColumn.cpp
+++ b/Source/modules/accessibility/AXTableColumn.cpp
@@ -38,7 +38,7 @@ namespace blink {
using namespace HTMLNames;
-AXTableColumn::AXTableColumn(AXObjectCacheImpl* axObjectCache)
+AXTableColumn::AXTableColumn(AXObjectCacheImpl& axObjectCache)
: AXMockObject(axObjectCache)
{
}
@@ -47,7 +47,7 @@ AXTableColumn::~AXTableColumn()
{
}
-PassRefPtr<AXTableColumn> AXTableColumn::create(AXObjectCacheImpl* axObjectCache)
+PassRefPtr<AXTableColumn> AXTableColumn::create(AXObjectCacheImpl& axObjectCache)
{
return adoptRef(new AXTableColumn(axObjectCache));
}
@@ -101,7 +101,7 @@ void AXTableColumn::headerObjectsForColumn(AccessibilityChildrenVector& headers)
if (!layoutCell)
continue;
- AXObject* cell = axObjectCache()->getOrCreate(layoutCell->node());
+ AXObject* cell = axObjectCache().getOrCreate(layoutCell->node());
if (!cell || !cell->isTableCell() || headers.contains(cell))
continue;
« no previous file with comments | « Source/modules/accessibility/AXTableColumn.h ('k') | Source/modules/accessibility/AXTableHeaderContainer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698