Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2045)

Unified Diff: Source/modules/accessibility/AXObject.h

Issue 1175533004: Refactor: Clear m_axObjectCache when AXObject detaches (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added ASSERT Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/accessibility/AXNodeObject.cpp ('k') | Source/modules/accessibility/AXObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXObject.h
diff --git a/Source/modules/accessibility/AXObject.h b/Source/modules/accessibility/AXObject.h
index 1fa46b3d1990e4d919b171cf63a6b0299dc030a8..165d9d8db7fe9e59578c8da5710e54240c180475 100644
--- a/Source/modules/accessibility/AXObject.h
+++ b/Source/modules/accessibility/AXObject.h
@@ -374,7 +374,7 @@ public:
};
protected:
- AXObject(AXObjectCacheImpl*);
+ AXObject(AXObjectCacheImpl&);
public:
virtual ~AXObject();
@@ -394,7 +394,11 @@ public:
virtual void setParent(AXObject* parent) { m_parent = parent; }
// The AXObjectCacheImpl that owns this object, and its unique ID within this cache.
- AXObjectCacheImpl* axObjectCache() const { return m_axObjectCache; }
+ AXObjectCacheImpl& axObjectCache() const
+ {
+ ASSERT(m_axObjectCache);
+ return *m_axObjectCache;
+ }
AXID axObjectID() const { return m_id; }
@@ -771,8 +775,6 @@ protected:
unsigned getLengthForTextRange() const { return text().length(); }
- bool m_detached;
-
mutable AXObject* m_parent;
// The following cached attribute values (the ones starting with m_cached*)
« no previous file with comments | « Source/modules/accessibility/AXNodeObject.cpp ('k') | Source/modules/accessibility/AXObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698