Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: Source/modules/accessibility/AXARIAGrid.cpp

Issue 1175533004: Refactor: Clear m_axObjectCache when AXObject detaches (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added ASSERT Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/accessibility/AXARIAGrid.h ('k') | Source/modules/accessibility/AXARIAGridCell.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXARIAGrid.cpp
diff --git a/Source/modules/accessibility/AXARIAGrid.cpp b/Source/modules/accessibility/AXARIAGrid.cpp
index 0d3349ac670a6ba9aded0d360c8b434d8106ede8..db5437ceebc17ae619bbad70d2cbf266c9389c46 100644
--- a/Source/modules/accessibility/AXARIAGrid.cpp
+++ b/Source/modules/accessibility/AXARIAGrid.cpp
@@ -37,7 +37,7 @@
namespace blink {
-AXARIAGrid::AXARIAGrid(LayoutObject* layoutObject, AXObjectCacheImpl* axObjectCache)
+AXARIAGrid::AXARIAGrid(LayoutObject* layoutObject, AXObjectCacheImpl& axObjectCache)
: AXTable(layoutObject, axObjectCache)
{
}
@@ -46,7 +46,7 @@ AXARIAGrid::~AXARIAGrid()
{
}
-PassRefPtr<AXARIAGrid> AXARIAGrid::create(LayoutObject* layoutObject, AXObjectCacheImpl* axObjectCache)
+PassRefPtr<AXARIAGrid> AXARIAGrid::create(LayoutObject* layoutObject, AXObjectCacheImpl& axObjectCache)
{
return adoptRef(new AXARIAGrid(layoutObject, axObjectCache));
}
@@ -92,7 +92,7 @@ void AXARIAGrid::addChildren()
if (!m_layoutObject)
return;
- AXObjectCacheImpl* axCache = axObjectCache();
+ AXObjectCacheImpl& axCache = axObjectCache();
// add only rows that are labeled as aria rows
HashSet<AXObject*> appendedRows;
@@ -114,7 +114,7 @@ void AXARIAGrid::addChildren()
// make the columns based on the number of columns in the first body
for (unsigned i = 0; i < columnCount; ++i) {
- AXTableColumn* column = toAXTableColumn(axCache->getOrCreate(ColumnRole));
+ AXTableColumn* column = toAXTableColumn(axCache.getOrCreate(ColumnRole));
column->setColumnIndex((int)i);
column->setParent(this);
m_columns.append(column);
« no previous file with comments | « Source/modules/accessibility/AXARIAGrid.h ('k') | Source/modules/accessibility/AXARIAGridCell.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698