Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Side by Side Diff: Source/modules/accessibility/AXTableRow.cpp

Issue 1175533004: Refactor: Clear m_axObjectCache when AXObject detaches (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added ASSERT Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/modules/accessibility/AXTableRow.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 20 matching lines...) Expand all
31 31
32 #include "core/layout/LayoutTableRow.h" 32 #include "core/layout/LayoutTableRow.h"
33 #include "modules/accessibility/AXObjectCacheImpl.h" 33 #include "modules/accessibility/AXObjectCacheImpl.h"
34 #include "modules/accessibility/AXTableCell.h" 34 #include "modules/accessibility/AXTableCell.h"
35 35
36 36
37 namespace blink { 37 namespace blink {
38 38
39 using namespace HTMLNames; 39 using namespace HTMLNames;
40 40
41 AXTableRow::AXTableRow(LayoutObject* layoutObject, AXObjectCacheImpl* axObjectCa che) 41 AXTableRow::AXTableRow(LayoutObject* layoutObject, AXObjectCacheImpl& axObjectCa che)
42 : AXLayoutObject(layoutObject, axObjectCache) 42 : AXLayoutObject(layoutObject, axObjectCache)
43 { 43 {
44 } 44 }
45 45
46 AXTableRow::~AXTableRow() 46 AXTableRow::~AXTableRow()
47 { 47 {
48 } 48 }
49 49
50 PassRefPtr<AXTableRow> AXTableRow::create(LayoutObject* layoutObject, AXObjectCa cheImpl* axObjectCache) 50 PassRefPtr<AXTableRow> AXTableRow::create(LayoutObject* layoutObject, AXObjectCa cheImpl& axObjectCache)
51 { 51 {
52 return adoptRef(new AXTableRow(layoutObject, axObjectCache)); 52 return adoptRef(new AXTableRow(layoutObject, axObjectCache));
53 } 53 }
54 54
55 AccessibilityRole AXTableRow::determineAccessibilityRole() 55 AccessibilityRole AXTableRow::determineAccessibilityRole()
56 { 56 {
57 if (!isTableRow()) 57 if (!isTableRow())
58 return AXLayoutObject::determineAccessibilityRole(); 58 return AXLayoutObject::determineAccessibilityRole();
59 59
60 if ((m_ariaRole = determineAriaRoleAttribute()) != UnknownRole) 60 if ((m_ariaRole = determineAriaRoleAttribute()) != UnknownRole)
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 for (const auto& cell : children()) { 113 for (const auto& cell : children()) {
114 if (!cell->isTableCell()) 114 if (!cell->isTableCell())
115 continue; 115 continue;
116 116
117 if (toAXTableCell(cell.get())->scanToDecideHeaderRole() == RowHeaderRole ) 117 if (toAXTableCell(cell.get())->scanToDecideHeaderRole() == RowHeaderRole )
118 headers.append(cell); 118 headers.append(cell);
119 } 119 }
120 } 120 }
121 121
122 } // namespace blink 122 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/accessibility/AXTableRow.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698