Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: Source/modules/accessibility/AXMenuListOption.cpp

Issue 1175533004: Refactor: Clear m_axObjectCache when AXObject detaches (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added ASSERT Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2010 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 15 matching lines...) Expand all
26 #include "config.h" 26 #include "config.h"
27 #include "modules/accessibility/AXMenuListOption.h" 27 #include "modules/accessibility/AXMenuListOption.h"
28 28
29 #include "modules/accessibility/AXMenuListPopup.h" 29 #include "modules/accessibility/AXMenuListPopup.h"
30 #include "modules/accessibility/AXObjectCacheImpl.h" 30 #include "modules/accessibility/AXObjectCacheImpl.h"
31 31
32 namespace blink { 32 namespace blink {
33 33
34 using namespace HTMLNames; 34 using namespace HTMLNames;
35 35
36 AXMenuListOption::AXMenuListOption(HTMLOptionElement* element, AXObjectCacheImpl * axObjectCache) 36 AXMenuListOption::AXMenuListOption(HTMLOptionElement* element, AXObjectCacheImpl & axObjectCache)
37 : AXMockObject(axObjectCache) 37 : AXMockObject(axObjectCache)
38 , m_element(element) 38 , m_element(element)
39 { 39 {
40 } 40 }
41 41
42 void AXMenuListOption::detach() 42 void AXMenuListOption::detach()
43 { 43 {
44 m_element = nullptr; 44 m_element = nullptr;
45 AXMockObject::detach(); 45 AXMockObject::detach();
46 } 46 }
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 109
110 return grandparent->elementRect(); 110 return grandparent->elementRect();
111 } 111 }
112 112
113 String AXMenuListOption::stringValue() const 113 String AXMenuListOption::stringValue() const
114 { 114 {
115 return m_element->text(); 115 return m_element->text();
116 } 116 }
117 117
118 } // namespace blink 118 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/accessibility/AXMenuListOption.h ('k') | Source/modules/accessibility/AXMenuListPopup.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698