Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: Source/modules/accessibility/AXList.cpp

Issue 1175533004: Refactor: Clear m_axObjectCache when AXObject detaches (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added ASSERT Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/modules/accessibility/AXList.h ('k') | Source/modules/accessibility/AXListBox.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 19 matching lines...) Expand all
30 #include "modules/accessibility/AXList.h" 30 #include "modules/accessibility/AXList.h"
31 31
32 #include "core/html/HTMLUListElement.h" 32 #include "core/html/HTMLUListElement.h"
33 #include "core/layout/LayoutObject.h" 33 #include "core/layout/LayoutObject.h"
34 #include "modules/accessibility/AXObjectCacheImpl.h" 34 #include "modules/accessibility/AXObjectCacheImpl.h"
35 35
36 namespace blink { 36 namespace blink {
37 37
38 using namespace HTMLNames; 38 using namespace HTMLNames;
39 39
40 AXList::AXList(LayoutObject* layoutObject, AXObjectCacheImpl* axObjectCache) 40 AXList::AXList(LayoutObject* layoutObject, AXObjectCacheImpl& axObjectCache)
41 : AXLayoutObject(layoutObject, axObjectCache) 41 : AXLayoutObject(layoutObject, axObjectCache)
42 { 42 {
43 } 43 }
44 44
45 AXList::~AXList() 45 AXList::~AXList()
46 { 46 {
47 } 47 }
48 48
49 PassRefPtr<AXList> AXList::create(LayoutObject* layoutObject, AXObjectCacheImpl* axObjectCache) 49 PassRefPtr<AXList> AXList::create(LayoutObject* layoutObject, AXObjectCacheImpl& axObjectCache)
50 { 50 {
51 return adoptRef(new AXList(layoutObject, axObjectCache)); 51 return adoptRef(new AXList(layoutObject, axObjectCache));
52 } 52 }
53 53
54 bool AXList::computeAccessibilityIsIgnored(IgnoredReasons* ignoredReasons) const 54 bool AXList::computeAccessibilityIsIgnored(IgnoredReasons* ignoredReasons) const
55 { 55 {
56 return accessibilityIsIgnoredByDefault(ignoredReasons); 56 return accessibilityIsIgnoredByDefault(ignoredReasons);
57 } 57 }
58 58
59 bool AXList::isDescriptionList() const 59 bool AXList::isDescriptionList() const
60 { 60 {
61 if (!m_layoutObject) 61 if (!m_layoutObject)
62 return false; 62 return false;
63 63
64 Node* node = m_layoutObject->node(); 64 Node* node = m_layoutObject->node();
65 return node && node->hasTagName(dlTag); 65 return node && node->hasTagName(dlTag);
66 } 66 }
67 67
68 AccessibilityRole AXList::roleValue() const 68 AccessibilityRole AXList::roleValue() const
69 { 69 {
70 if (isDescriptionList()) 70 if (isDescriptionList())
71 return DescriptionListRole; 71 return DescriptionListRole;
72 72
73 return ListRole; 73 return ListRole;
74 } 74 }
75 } // namespace blink 75 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/accessibility/AXList.h ('k') | Source/modules/accessibility/AXListBox.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698