Object pool with support for untagged entries.

runtime/vm/code_patcher_x64.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_X64.
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/assembler.h"
 #include "vm/code_patcher.h"
 #include "vm/cpu.h"
 #include "vm/dart_entry.h"
 #include "vm/flow_graph_compiler.h"
 #include "vm/instructions.h"
 #include "vm/object.h"
 #include "vm/raw_object.h"
 
 namespace dart {
 
 // The expected pattern of a Dart unoptimized call (static and instance):
 //   0: 49 8b 9f imm32  mov RBX, [PP + off]
 //   7: 41 ff 97 imm32  call [PP + off]
 //  14 <- return address
 class UnoptimizedCall : public ValueObject {
  public:
   UnoptimizedCall(uword return_address, const Code& code)
       : start_(return_address - kCallPatternSize),
-        object_pool_(Array::Handle(code.ObjectPool())) {
+        object_pool_(ObjectPool::Handle(code.GetObjectPool())) {
     ASSERT(IsValid(return_address));
     ASSERT((kCallPatternSize - 7) == Assembler::kCallExternalLabelSize);
   }
 
   static const int kCallPatternSize = 14;
 
   static bool IsValid(uword return_address) {
     uint8_t* code_bytes =
         reinterpret_cast<uint8_t*>(return_address - kCallPatternSize);
     return (code_bytes[0] == 0x49) && (code_bytes[1] == 0x8B) &&
            (code_bytes[2] == 0x9F) &&
            (code_bytes[7] == 0x41) && (code_bytes[8] == 0xFF) &&
            (code_bytes[9] == 0x97);
   }
 
   RawObject* ic_data() const {
     intptr_t index = InstructionPattern::IndexFromPPLoad(start_ + 3);
-    return object_pool_.At(index);
+    return object_pool_.ObjectAt(index);
   }
 
   uword target() const {
     intptr_t index = InstructionPattern::IndexFromPPLoad(start_ + 10);
-    return reinterpret_cast<uword>(object_pool_.At(index));
+    return object_pool_.RawValueAt(index);
   }
 
   void set_target(uword target) const {
     intptr_t index = InstructionPattern::IndexFromPPLoad(start_ + 10);
-    const Smi& smi = Smi::Handle(reinterpret_cast<RawSmi*>(target));
-    object_pool_.SetAt(index, smi);
+    object_pool_.SetRawValueAt(index, target);
     // No need to flush the instruction cache, since the code is not modified.
   }
 
  private:
   uword start_;
-  const Array& object_pool_;
+  const ObjectPool& object_pool_;
   DISALLOW_IMPLICIT_CONSTRUCTORS(UnoptimizedCall);
 };
 
 
 class InstanceCall : public UnoptimizedCall {
  public:
   InstanceCall(uword return_address, const Code& code)
       : UnoptimizedCall(return_address, code) {
 #if defined(DEBUG)
     ICData& test_ic_data = ICData::Handle();
@@ skipping 24 matching lines @@
 
 
 // The expected pattern of a call where the target is loaded from
 // the object pool:
 //   0: 41 ff 97 imm32  call [PP + off]
 //   7: <- return address
 class PoolPointerCall : public ValueObject {
  public:
   explicit PoolPointerCall(uword return_address, const Code& code)
       : start_(return_address - kCallPatternSize),
-        object_pool_(Array::Handle(code.ObjectPool())) {
+        object_pool_(ObjectPool::Handle(code.GetObjectPool())) {
     ASSERT(IsValid(return_address));
   }
 
   static const int kCallPatternSize = 7;
 
   static bool IsValid(uword return_address) {
     uint8_t* code_bytes =
         reinterpret_cast<uint8_t*>(return_address - kCallPatternSize);
     return (code_bytes[0] == 0x41) && (code_bytes[1] == 0xFF) &&
            (code_bytes[2] == 0x97);
   }
 
   intptr_t pp_index() const {
     return InstructionPattern::IndexFromPPLoad(start_ + 3);
   }
 
   uword Target() const {
-    return reinterpret_cast<uword>(object_pool_.At(pp_index()));
+    return reinterpret_cast<uword>(object_pool_.RawValueAt(pp_index()));
   }
 
   void SetTarget(uword target) const {
-    const Smi& smi = Smi::Handle(reinterpret_cast<RawSmi*>(target));
-    object_pool_.SetAt(pp_index(), smi);
+    object_pool_.SetRawValueAt(pp_index(), target);
     // No need to flush the instruction cache, since the code is not modified.
   }
 
  protected:
   uword start_;
-  const Array& object_pool_;
+  const ObjectPool& object_pool_;
 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(PoolPointerCall);
 };
 
 
 uword CodePatcher::GetStaticCallTargetAt(uword return_address,
                                          const Code& code) {
   ASSERT(code.ContainsInstructionAt(return_address));
   PoolPointerCall call(return_address, code);
@@ skipping 65 matching lines @@
   return ic_data.GetTargetAt(0);
 }
 
 
 // The expected code pattern of an edge counter in unoptimized code:
 //  49 8b 87 imm32    mov RAX, [PP + offset]
 class EdgeCounter : public ValueObject {
  public:
   EdgeCounter(uword pc, const Code& code)
       : end_(pc - FlowGraphCompiler::EdgeCounterIncrementSizeInBytes()),
-        object_pool_(Array::Handle(code.ObjectPool())) {
+        object_pool_(ObjectPool::Handle(code.GetObjectPool())) {
     ASSERT(IsValid(end_));
   }
 
   static bool IsValid(uword end) {
     uint8_t* bytes = reinterpret_cast<uint8_t*>(end - 7);
     return (bytes[0] == 0x49) && (bytes[1] == 0x8b) && (bytes[2] == 0x87);
   }
 
   RawObject* edge_counter() const {
-    return object_pool_.At(InstructionPattern::IndexFromPPLoad(end_ - 4));
+    return object_pool_.ObjectAt(InstructionPattern::IndexFromPPLoad(end_ - 4));
   }
 
  private:
   uword end_;
-  const Array& object_pool_;
+  const ObjectPool& object_pool_;
 };
 
 
 RawObject* CodePatcher::GetEdgeCounterAt(uword pc, const Code& code) {
   ASSERT(code.ContainsInstructionAt(pc));
   EdgeCounter counter(pc, code);
   return counter.edge_counter();
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64