Object pool with support for untagged entries.

runtime/vm/assembler_arm64.cc

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // NOLINT
 #if defined(TARGET_ARCH_ARM64)
 
 #include "vm/assembler.h"
 #include "vm/cpu.h"
 #include "vm/longjump.h"
@@ skipping 17 matching lines @@
 Assembler::Assembler(bool use_far_branches)
     : buffer_(),
       prologue_offset_(-1),
       use_far_branches_(use_far_branches),
       comments_(),
       allow_constant_pool_(true) {
   if (Isolate::Current() != Dart::vm_isolate()) {
     // These objects and labels need to be accessible through every pool-pointer
     // at the same index.
     intptr_t index =
-        object_pool_.AddObject(Object::null_object(), kNotPatchable);
+        object_pool_.AddObject(Object::null_object());
     ASSERT(index == 0);
 
-    index = object_pool_.AddObject(Bool::True(), kNotPatchable);
+    index = object_pool_.AddObject(Bool::True());
     ASSERT(index == 1);
 
-    index = object_pool_.AddObject(Bool::False(), kNotPatchable);
+    index = object_pool_.AddObject(Bool::False());
     ASSERT(index == 2);
 
     const Smi& vacant = Smi::Handle(Smi::New(0xfa >> kSmiTagShift));
     StubCode* stub_code = Isolate::Current()->stub_code();
     if (stub_code->UpdateStoreBuffer_entry() != NULL) {
       object_pool_.AddExternalLabel(
           &stub_code->UpdateStoreBufferLabel(), kNotPatchable);
     } else {
-      object_pool_.AddObject(vacant, kNotPatchable);
+      object_pool_.AddObject(vacant);
     }
 
     if (stub_code->CallToRuntime_entry() != NULL) {
       object_pool_.AddExternalLabel(
           &stub_code->CallToRuntimeLabel(), kNotPatchable);
     } else {
-      object_pool_.AddObject(vacant, kNotPatchable);
+      object_pool_.AddObject(vacant);
     }
   }
 }
 
 
 void Assembler::InitializeMemoryWithBreakpoints(uword data, intptr_t length) {
   ASSERT(Utils::IsAligned(data, 4));
   ASSERT(Utils::IsAligned(length, 4));
   const uword end = data + length;
   while (data < end) {
@@ skipping 312 matching lines @@
       Operand::CanHold(upper20, kXRegSizeInBits, &op);
   ASSERT(ot == Operand::Immediate);
   ASSERT(Address::CanHoldOffset(lower12));
   add(dst, pp, op);
   ldr(dst, Address(dst, lower12));
 }
 
 
 intptr_t Assembler::FindImmediate(int64_t imm) {
   ASSERT(Isolate::Current() != Dart::vm_isolate());
-  const Smi& smi = Smi::Handle(reinterpret_cast<RawSmi*>(imm));
-  return object_pool_.FindObject(smi, kNotPatchable);
+  return object_pool_.FindImmediate(imm);
 }
 
 
 // A set of VM objects that are present in every constant pool.
 static bool IsAlwaysInConstantPool(const Object& object) {
   // TODO(zra): Evaluate putting all VM heap objects into the pool.
   return (object.raw() == Object::null())
       || (object.raw() == Bool::True().raw())
       || (object.raw() == Bool::False().raw());
 }
@@ skipping 29 matching lines @@
          (Isolate::Current() != Dart::vm_isolate());
 }
 
 
 void Assembler::LoadExternalLabel(Register dst,
                                   const ExternalLabel* label,
                                   Patchability patchable,
                                   Register pp) {
   const int64_t target = static_cast<int64_t>(label->address());
   if (CanLoadImmediateFromPool(target, pp)) {
-    const int32_t offset =
-        Array::element_offset(object_pool_.FindExternalLabel(label, patchable));
+    const int32_t offset = ObjectPool::element_offset(
+        object_pool_.FindExternalLabel(label, patchable));
     LoadWordFromPoolOffset(dst, pp, offset);
   } else {
     LoadImmediate(dst, target, kNoPP);
   }
 }
 
 
 void Assembler::LoadExternalLabelFixed(Register dst,
                                        const ExternalLabel* label,
                                        Patchability patchable,
                                        Register pp) {
-  const int32_t offset =
-      Array::element_offset(object_pool_.FindExternalLabel(label, patchable));
+  const int32_t offset = ObjectPool::element_offset(
+      object_pool_.FindExternalLabel(label, patchable));
   LoadWordFromPoolOffsetFixed(dst, pp, offset);
 }
 
 
 void Assembler::LoadIsolate(Register dst, Register pp) {
   ldr(dst, Address(THR, Thread::isolate_offset()));
 }
 
 
 void Assembler::LoadObject(Register dst, const Object& object, Register pp) {
   if (CanLoadObjectFromPool(object)) {
     const int32_t offset =
-        Array::element_offset(object_pool_.FindObject(object, kNotPatchable));
+        ObjectPool::element_offset(object_pool_.FindObject(object));
     LoadWordFromPoolOffset(dst, pp, offset);
   } else {
     ASSERT((Isolate::Current() == Dart::vm_isolate()) ||
            object.IsSmi() ||
            object.InVMHeap());
     LoadDecodableImmediate(dst, reinterpret_cast<int64_t>(object.raw()), pp);
   }
 }
 
 
 void Assembler::CompareObject(Register reg, const Object& object, Register pp) {
   if (CanLoadObjectFromPool(object)) {
     LoadObject(TMP, object, pp);
     CompareRegisters(reg, TMP);
   } else {
     CompareImmediate(reg, reinterpret_cast<int64_t>(object.raw()), pp);
   }
 }
 
 
 void Assembler::LoadDecodableImmediate(Register reg, int64_t imm, Register pp) {
   if ((pp != kNoPP) &&
       (Isolate::Current() != Dart::vm_isolate()) &&
       allow_constant_pool()) {
     int64_t val_smi_tag = imm & kSmiTagMask;
     imm &= ~kSmiTagMask;  // Mask off the tag bits.
-    const int32_t offset = Array::element_offset(FindImmediate(imm));
+    const int32_t offset = ObjectPool::element_offset(FindImmediate(imm));
     LoadWordFromPoolOffset(reg, pp, offset);
     if (val_smi_tag != 0) {
       // Add back the tag bits.
       orri(reg, reg, Immediate(val_smi_tag));
     }
   } else {
     // TODO(zra): Since this sequence only needs to be decodable, it can be
     // of variable length.
     LoadImmediateFixed(reg, imm);
   }
@@ skipping 15 matching lines @@
 
 
 void Assembler::LoadImmediate(Register reg, int64_t imm, Register pp) {
   Comment("LoadImmediate");
   if (CanLoadImmediateFromPool(imm, pp)) {
     // It's a 64-bit constant and we're not in the VM isolate, so load from
     // object pool.
     // Save the bits that must be masked-off for the SmiTag
     int64_t val_smi_tag = imm & kSmiTagMask;
     imm &= ~kSmiTagMask;  // Mask off the tag bits.
-    const int32_t offset = Array::element_offset(FindImmediate(imm));
+    const int32_t offset = ObjectPool::element_offset(FindImmediate(imm));
     LoadWordFromPoolOffset(reg, pp, offset);
     if (val_smi_tag != 0) {
       // Add back the tag bits.
       orri(reg, reg, Immediate(val_smi_tag));
     }
   } else {
     // 0. Is it 0?
     if (imm == 0) {
       movz(reg, Immediate(0), 0);
       return;
@@ skipping 917 matching lines @@
     add(base, array, Operand(index, LSL, shift));
   }
   const OperandSize size = Address::OperandSizeFor(cid);
   ASSERT(Address::CanHoldOffset(offset, Address::Offset, size));
   return Address(base, offset, Address::Offset, size);
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_ARM64