Object pool with support for untagged entries.

runtime/vm/assembler_arm.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_ASSEMBLER_ARM_H_
 #define VM_ASSEMBLER_ARM_H_
 
 #ifndef VM_ASSEMBLER_H_
 #error Do not include assembler_arm.h directly; use assembler.h instead.
 #endif
@@ skipping 323 matching lines @@
 
   // Count the fixups that produce a pointer offset, without processing
   // the fixups.  On ARM there are no pointers in code.
   intptr_t CountPointerOffsets() const { return 0; }
 
   const ZoneGrowableArray<intptr_t>& GetPointerOffsets() const {
     ASSERT(buffer_.pointer_offsets().length() == 0);  // No pointers in code.
     return buffer_.pointer_offsets();
   }
 
-  const GrowableObjectArray& object_pool_data() const {
-    return object_pool_.data();
-  }
+  ObjectPoolHelper& object_pool() { return object_pool_; }

[srdjan, 2015/06/09 21:49:46]

Should you rename object_pool_ and related, since it is actually not the
object_pool that you are returning?
ObjectPoolHelper is slightly clumsy name, IMO. Maybe ObjectPoolWrapper?

[Florian Schneider, 2015/06/10 08:26:17]

Done.

 
-  ObjectPool& object_pool() { return object_pool_; }
+  RawObjectPool* MakeObjectPool() { return object_pool_.MakeObjectPool(); }
 
   bool use_far_branches() const {
     return FLAG_use_far_branches || use_far_branches_;
   }
 
 #if defined(TESTING) || defined(DEBUG)
   // Used in unit tests and to ensure predictable verification code size in
   // FlowGraphCompiler::EmitEdgeCounter.
   void set_use_far_branches(bool b) {
     use_far_branches_ = b;
@@ skipping 595 matching lines @@
 
   bool allow_constant_pool() const {
     return allow_constant_pool_;
   }
   void set_allow_constant_pool(bool b) {
     allow_constant_pool_ = b;
   }
 
  private:
   AssemblerBuffer buffer_;  // Contains position independent code.
-  ObjectPool object_pool_;  // Objects and patchable jump targets.
+  ObjectPoolHelper object_pool_;  // Objects and patchable jump targets.
 
   int32_t prologue_offset_;
 
   bool use_far_branches_;
 
   // If you are thinking of using one or both of these instructions directly,
   // instead LoadImmediate should probably be used.
   void movw(Register rd, uint16_t imm16, Condition cond = AL);
   void movt(Register rd, uint16_t imm16, Condition cond = AL);
 
@@ skipping 147 matching lines @@
                      Register new_value,
                      FieldContent old_content);
 
   DISALLOW_ALLOCATION();
   DISALLOW_COPY_AND_ASSIGN(Assembler);
 };
 
 }  // namespace dart
 
 #endif  // VM_ASSEMBLER_ARM_H_