Object pool with support for untagged entries.

runtime/vm/raw_object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_RAW_OBJECT_H_
 #define VM_RAW_OBJECT_H_
 
 #include "platform/assert.h"
 #include "vm/atomic.h"
 #include "vm/globals.h"
@@ skipping 13 matching lines @@
   V(ClosureData)                                                               \
   V(RedirectionData)                                                           \
   V(Field)                                                                     \
   V(LiteralToken)                                                              \
   V(TokenStream)                                                               \
   V(Script)                                                                    \
   V(Library)                                                                   \
   V(Namespace)                                                                 \
   V(Code)                                                                      \
   V(Instructions)                                                              \
+  V(ObjectPool)                                                                \
   V(PcDescriptors)                                                             \
   V(Stackmap)                                                                  \
   V(LocalVarDescriptors)                                                       \
   V(ExceptionHandlers)                                                         \
   V(Context)                                                                   \
   V(ContextScope)                                                              \
   V(ICData)                                                                    \
   V(MegamorphicCache)                                                          \
   V(SubtypeTestCache)                                                          \
   V(Error)                                                                     \
@@ skipping 951 matching lines @@
   // Variable length data follows here.
   int32_t* data() { OPEN_ARRAY_START(int32_t, int32_t); }
   const int32_t* data() const { OPEN_ARRAY_START(int32_t, int32_t); }
 
   friend class Function;
   friend class MarkingVisitor;
   friend class StackFrame;
 };
 
 
+class RawObjectPool : public RawObject {
+  RAW_HEAP_OBJECT_IMPLEMENTATION(ObjectPool);
+
+  intptr_t length_;
+  RawTypedData* info_array_;

[Florian Schneider, 2015/06/09 13:23:08]

This int8-array holds the entry-type for each entry in the object pool.

+
+  struct Entry {
+    union {
+      RawObject* raw_obj_;
+      uword raw_value_;
+    };
+  };
+  Entry* data() { OPEN_ARRAY_START(Entry, Entry); }
+  Entry const* data() const { OPEN_ARRAY_START(Entry, Entry); }
+
+  Entry* first_entry() { return &ptr()->data()[0]; }
+
+  friend class Object;
+};
+
+
 class RawInstructions : public RawObject {
   RAW_HEAP_OBJECT_IMPLEMENTATION(Instructions);
 
   RawObject** from() {
     return reinterpret_cast<RawObject**>(&ptr()->code_);
   }
   RawCode* code_;
-  RawArray* object_pool_;
+  RawObjectPool* object_pool_;
   RawObject** to() {
     return reinterpret_cast<RawObject**>(&ptr()->object_pool_);
   }
   int32_t size_;
 
   // Variable length data follows here.
   uint8_t* data() { OPEN_ARRAY_START(uint8_t, uint8_t); }
 
   // Private helper function used while visiting stack frames. The
   // code which iterates over dart frames is also called during GC and
@@ skipping 750 matching lines @@
   RawSmi* length_;
   // Variable length data follows here.
   uint8_t* data() { OPEN_ARRAY_START(uint8_t, uint8_t); }
   const uint8_t* data() const { OPEN_ARRAY_START(uint8_t, uint8_t); }
   RawObject** to() { return reinterpret_cast<RawObject**>(&ptr()->length_); }
 
   friend class Api;
   friend class Object;
   friend class Instance;
   friend class SnapshotReader;
+  friend class ObjectPool;
+  friend class RawObjectPool;
 };
 
 
 class RawExternalTypedData : public RawInstance {
   RAW_HEAP_OBJECT_IMPLEMENTATION(ExternalTypedData);
 
  protected:
   RawObject** from() { return reinterpret_cast<RawObject**>(&ptr()->length_); }
   RawSmi* length_;
   RawObject** to() { return reinterpret_cast<RawObject**>(&ptr()->length_); }
@@ skipping 312 matching lines @@
 
 inline bool RawObject::IsVariableSizeClassId(intptr_t index) {
   return (index == kArrayCid) ||
          (index == kImmutableArrayCid) ||
          RawObject::IsOneByteStringClassId(index) ||
          RawObject::IsTwoByteStringClassId(index) ||
          RawObject::IsTypedDataClassId(index) ||
          (index == kContextCid) ||
          (index == kTypeArgumentsCid) ||
          (index == kInstructionsCid) ||
+         (index == kObjectPoolCid) ||
          (index == kPcDescriptorsCid) ||
          (index == kStackmapCid) ||
          (index == kLocalVarDescriptorsCid) ||
          (index == kExceptionHandlersCid) ||
          (index == kCodeCid) ||
          (index == kContextScopeCid) ||
          (index == kInstanceCid) ||
          (index == kJSRegExpCid);
 }
 
@@ skipping 12 matching lines @@
   COMPILE_ASSERT(kExternalTypedDataInt8ArrayCid ==
                  kTypedDataInt8ArrayViewCid + 15);
   COMPILE_ASSERT(kByteBufferCid == kExternalTypedDataInt8ArrayCid + 14);
   COMPILE_ASSERT(kNullCid == kByteBufferCid + 1);
   return (kNullCid - kTypedDataInt8ArrayCid);
 }
 
 }  // namespace dart
 
 #endif  // VM_RAW_OBJECT_H_