Object pool with support for untagged entries.

runtime/vm/instructions_mips.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_MIPS.
 #if defined(TARGET_ARCH_MIPS)
 
 #include "vm/constants_mips.h"
 #include "vm/cpu.h"
 #include "vm/instructions.h"
 #include "vm/object.h"
 
 namespace dart {
 
 CallPattern::CallPattern(uword pc, const Code& code)
-    : object_pool_(Array::Handle(code.ObjectPool())),
+    : object_pool_(ObjectPool::Handle(code.GetObjectPool())),
       end_(pc),
       args_desc_load_end_(0),
       ic_data_load_end_(0),
       target_address_pool_index_(-1),
       args_desc_(Array::Handle()),
       ic_data_(ICData::Handle()) {
   ASSERT(code.ContainsInstructionAt(pc));
   // Last instruction: jalr RA, T9(=R25).
   ASSERT(*(reinterpret_cast<uword*>(end_) - 2) == 0x0320f809);
   Register reg;
   // The end of the pattern is the instruction after the delay slot of the jalr.
   ic_data_load_end_ =
       InstructionPattern::DecodeLoadWordFromPool(end_ - (2 * Instr::kInstrSize),
                                                  &reg,
                                                  &target_address_pool_index_);
   ASSERT(reg == T9);
 }
 
 
 // Decodes a load sequence ending at 'end' (the last instruction of the load
 // sequence is the instruction before the one at end).  Returns a pointer to
 // the first instruction in the sequence.  Returns the register being loaded
 // and the loaded object in the output parameters 'reg' and 'obj'
 // respectively.
 uword InstructionPattern::DecodeLoadObject(uword end,
-                                           const Array& object_pool,
+                                           const ObjectPool& object_pool,
                                            Register* reg,
                                            Object* obj) {
   uword start = 0;
   Instr* instr = Instr::At(end - Instr::kInstrSize);
   if (instr->OpcodeField() == LW) {
     intptr_t index = 0;
     start = DecodeLoadWordFromPool(end, reg, &index);
-    *obj = object_pool.At(index);
+    *obj = object_pool.ObjectAt(index);
   } else {
     intptr_t value = 0;
     start = DecodeLoadWordImmediate(end, reg, &value);
     *obj = reinterpret_cast<RawObject*>(value);
   }
   return start;
 }
 
 
 // Decodes a load sequence ending at 'end' (the last instruction of the load
@@ skipping 86 matching lines @@
                                          object_pool_,
                                          &reg,
                                          &args_desc_);
     ASSERT(reg == S4);
   }
   return args_desc_.raw();
 }
 
 
 uword CallPattern::TargetAddress() const {
-  ASSERT(target_address_pool_index_ >= 0);
-  const Object& target_address =
-      Object::Handle(object_pool_.At(target_address_pool_index_));
-  ASSERT(target_address.IsSmi());
-  // The address is stored in the object array as a RawSmi.
-  return reinterpret_cast<uword>(target_address.raw());
+  return object_pool_.RawValueAt(target_address_pool_index_);
 }
 
 
 void CallPattern::SetTargetAddress(uword target_address) const {
-  ASSERT(Utils::IsAligned(target_address, 4));
-  // The address is stored in the object array as a RawSmi.
-  const Smi& smi = Smi::Handle(reinterpret_cast<RawSmi*>(target_address));
-  object_pool_.SetAt(target_address_pool_index_, smi);
+  object_pool_.SetRawValueAt(target_address_pool_index_, target_address);
   // No need to flush the instruction cache, since the code is not modified.
 }
 
 
 void CallPattern::InsertAt(uword pc, uword target_address) {
   Instr* lui = Instr::At(pc + (0 * Instr::kInstrSize));
   Instr* ori = Instr::At(pc + (1 * Instr::kInstrSize));
   Instr* jr = Instr::At(pc + (2 * Instr::kInstrSize));
   Instr* nop = Instr::At(pc + (3 * Instr::kInstrSize));
   uint16_t target_lo = target_address & 0xffff;
@@ skipping 55 matching lines @@
 bool ReturnPattern::IsValid() const {
   Instr* jr = Instr::At(pc_);
   return (jr->OpcodeField() == SPECIAL) &&
          (jr->FunctionField() == JR) &&
          (jr->RsField() == RA);
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_MIPS