Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: public/web/WebSharedWorker.h

Issue 1175463004: Cleanup: Remove WeakPtr usage in WebSharedWorkerImpl (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: more documentation Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebSharedWorkerImpl.cpp ('k') | public/web/WebSharedWorkerClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebSharedWorker.h
diff --git a/public/web/WebSharedWorker.h b/public/web/WebSharedWorker.h
index a081096ef742778d02cc77e715e2d1bdca92d85d..407d3d1d2222485b90ae1cbcf22a25b49a954714 100644
--- a/public/web/WebSharedWorker.h
+++ b/public/web/WebSharedWorker.h
@@ -44,7 +44,9 @@ class WebURL;
// This is the interface to a SharedWorker thread.
class WebSharedWorker {
public:
- // Invoked from the worker thread to instantiate a WebSharedWorker that interacts with the WebKit worker components.
+ // Instantiate a WebSharedWorker that interacts with the shared worker.
+ // WebSharedWorkerClient given here must outlive or have the identical
+ // lifetime as this instance.
BLINK_EXPORT static WebSharedWorker* create(WebSharedWorkerClient*);
virtual void startWorkerContext(
@@ -56,12 +58,9 @@ public:
// Sends a connect event to the SharedWorker context.
virtual void connect(WebMessagePortChannel*) = 0;
- // Invoked to shutdown the worker when there are no more associated documents.
+ // Invoked to shutdown the worker when there are no more associated documents. This eventually deletes this instance.
virtual void terminateWorkerContext() = 0;
- // Notification when the WebCommonWorkerClient is destroyed.
- virtual void clientDestroyed() = 0;
-
virtual void pauseWorkerContextOnStart() = 0;
virtual void attachDevTools(const WebString& hostId) = 0;
virtual void reattachDevTools(const WebString& hostId, const WebString& savedState) = 0;
« no previous file with comments | « Source/web/WebSharedWorkerImpl.cpp ('k') | public/web/WebSharedWorkerClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698