Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1395)

Unified Diff: Source/web/WebSharedWorkerImpl.h

Issue 1175463004: Cleanup: Remove WeakPtr usage in WebSharedWorkerImpl (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: more documentation Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/web/WebSharedWorkerImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebSharedWorkerImpl.h
diff --git a/Source/web/WebSharedWorkerImpl.h b/Source/web/WebSharedWorkerImpl.h
index 5491eda13c8f46383ea3ded772a8efe195f1a925..002773c696d48d2ce6522b9b06744bd5c8b1a906 100644
--- a/Source/web/WebSharedWorkerImpl.h
+++ b/Source/web/WebSharedWorkerImpl.h
@@ -98,7 +98,6 @@ public:
virtual void startWorkerContext(const WebURL&, const WebString& name, const WebString& contentSecurityPolicy, WebContentSecurityPolicyType) override;
virtual void connect(WebMessagePortChannel*) override;
virtual void terminateWorkerContext() override;
- virtual void clientDestroyed() override;
virtual void pauseWorkerContextOnStart() override;
virtual void attachDevTools(const WebString& hostId) override;
@@ -111,8 +110,6 @@ private:
virtual ~WebSharedWorkerImpl();
- WebSharedWorkerClient* client() { return m_client->get(); }
-
void setWorkerThread(PassRefPtr<WorkerThread> thread) { m_workerThread = thread; }
WorkerThread* workerThread() { return m_workerThread.get(); }
@@ -150,13 +147,7 @@ private:
RefPtr<WorkerThread> m_workerThread;
- // This one's initialized and bound to the main thread.
- RefPtr<WeakReference<WebSharedWorkerClient>> m_client;
-
- // Usually WeakPtr is created by WeakPtrFactory exposed by Client
- // class itself, but here it's implemented by Chrome so we create
- // our own WeakPtr.
- WeakPtr<WebSharedWorkerClient> m_clientWeakPtr;
+ WebSharedWorkerClient* m_client;
bool m_pauseWorkerContextOnStart;
bool m_isPausedOnStart;
« no previous file with comments | « no previous file | Source/web/WebSharedWorkerImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698