Cleanup: Remove WeakPtr usage in WebSharedWorkerImpl

Cleanup: Remove WeakPtr usage in WebSharedWorkerImpl

This one no longer seems necessary.
(WebSharedWorkerClient's implementation holds WebSharedWorkerImpl, so
it seems m_client never becomes invalid while the worker's around)

BUG=n/a
TEST=buildbot

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197065

[kinuko, 2015-06-10 16:10:48]

kinuko@chromium.org changed reviewers:
+ mkwst@chromium.org

[kinuko, 2015-06-10 16:11:28]

PTL

[kinuko, 2015-06-11 23:08:57]

kinuko@chromium.org changed reviewers:
+ tkent@chromium.org

[kinuko, 2015-06-11 23:09:32]

kinuko@chromium.org changed reviewers:
- mkwst@chromium.org

[kinuko, 2015-06-11 23:11:39]

Kent-san, can you review this?

[tkent, 2015-06-12 00:16:27]

lgtm.

Can you add a comment about WebSharedWorker&WebSharedWorkerClient lifetime
assumption to WebSharedWorker.h and/or WebSharedWorkerClient.h?

[kinuko, 2015-06-12 01:00:14]

On 2015/06/12 00:16:27, tkent wrote:
> lgtm.
> 
> Can you add a comment about WebSharedWorker&WebSharedWorkerClient lifetime
> assumption to WebSharedWorker.h and/or WebSharedWorkerClient.h?

Thanks, sure, will do.

[kinuko, 2015-06-12 09:24:35]

On 2015/06/12 01:00:14, kinuko wrote:
> On 2015/06/12 00:16:27, tkent wrote:
> > lgtm.
> > 
> > Can you add a comment about WebSharedWorker&WebSharedWorkerClient lifetime
> > assumption to WebSharedWorker.h and/or WebSharedWorkerClient.h?

Added documentation in WebSharedWorker{,Client}.h, and also removed extra
null-checks for m_client as it's not weakptr any more.

Will be landing tonight or tomorrow unless I get further comments.

[kinuko, 2015-06-12 22:22:57]

The CQ bit was checked by kinuko@chromium.org

[kinuko, 2015-06-12 22:22:57]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/1175463004/#ps40001
(title: "more documentation")

[commit-bot: I haz the power, 2015-06-12 22:23:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1175463004/40001

[commit-bot: I haz the power, 2015-06-12 22:27:35]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197065