Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1175463003: MIPS: Replace numeric_limits<>::lowest() in cctest-assembler*.cc (Closed)

Created:
5 years, 6 months ago by balazs.kilvady
Modified:
5 years, 6 months ago
Reviewers:
djordje.pesic, paul.l..., dusmil.imgtec, akos.palfi.imgtec
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Replace numeric_limits<>::lowest() in cctest-assembler*.cc On Mac for the requested minimal version (10.5) only old stl (from gcc 4.2.1) can be used so unfortunately we can't use numeric_limits<>::lowest() which were added in 874c54e05e92e04590b1026b495108abfd6063b7 BUG= TEST=cctest/test-assembler-mips64, cctest/test-assembler-mips Committed: https://crrev.com/f51e507264799742304cbed7a8095525c5a0cfe1 Cr-Commit-Position: refs/heads/master@{#28907}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -40 lines) Patch
M test/cctest/test-assembler-mips.cc View 7 chunks +20 lines, -20 lines 0 comments Download
M test/cctest/test-assembler-mips64.cc View 7 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
balazs.kilvady
5 years, 6 months ago (2015-06-10 12:53:43 UTC) #2
dusmil.imgtec
LGTM.
5 years, 6 months ago (2015-06-10 14:36:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175463003/1
5 years, 6 months ago (2015-06-10 15:19:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 15:45:12 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 15:45:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f51e507264799742304cbed7a8095525c5a0cfe1
Cr-Commit-Position: refs/heads/master@{#28907}

Powered by Google App Engine
This is Rietveld 408576698