Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 1175423007: Create an example app that demonstrates interactive coordination of an fn tree and a raw RenderObje… (Closed)

Created:
5 years, 6 months ago by Hixie
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Create an example app that demonstrates interactive coordination of an fn tree and a raw RenderObject tree. Sector changes: - implement the intrinsic sizing box API on RenderBoxToRenderSectorAdapter - remove some debug print statements - fix getIntrinsicDimensions() on RenderSolidColor to return true values - factor out the default demo RenderObject changes: - BoxConstraints.isInfinite() now returns true only if both dimensions are infinite fn changes: - implement UINodeToRenderBoxAdapter - rename RenderObjectToUINodeAdapter to RenderBoxToUINodeAdapter Tests: - add a test for sector layout - make TestRenderView support being run without the unit test framework R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/af115cd473a531b68a8641d3557b59a8b5bd769a

Patch Set 1 #

Patch Set 2 : #

Total comments: 5

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -30 lines) Patch
M sky/examples/rendering/sector_layout.dart View 6 chunks +34 lines, -14 lines 0 comments Download
M sky/examples/stocks2/lib/stock_app.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
A sky/examples/widgets/sector.dart View 1 2 1 chunk +145 lines, -0 lines 0 comments Download
M sky/examples/widgets/spinning_mixed.dart View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M sky/sdk/lib/rendering/box.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/basic.dart View 1 2 2 chunks +28 lines, -1 line 0 comments Download
M sky/sdk/lib/widgets/ui_node.dart View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + sky/tests/raw/sector_layout.dart View 1 chunk +4 lines, -7 lines 0 comments Download
A sky/tests/raw/sector_layout-expected.txt View 1 chunk +27 lines, -0 lines 0 comments Download
M sky/tests/resources/display_list.dart View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm https://codereview.chromium.org/1175423007/diff/20001/sky/examples/widgets/sector.dart File sky/examples/widgets/sector.dart (right): https://codereview.chromium.org/1175423007/diff/20001/sky/examples/widgets/sector.dart#newcode28 sky/examples/widgets/sector.dart:28: class ContainerApp extends App { s/ContainerApp/SectorApp/ https://codereview.chromium.org/1175423007/diff/20001/sky/examples/widgets/sector.dart#newcode41 sky/examples/widgets/sector.dart:41: ...
5 years, 6 months ago (2015-06-16 02:32:35 UTC) #2
Hixie
5 years, 6 months ago (2015-06-16 16:29:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
af115cd473a531b68a8641d3557b59a8b5bd769a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698