Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: sky/engine/core/painting/DrawLooperLayerInfo.idl

Issue 1175403002: Expose and use constants for DrawLooperLayerInfo.setPaintBits to dart. (Closed) Base URL: git@github.com:/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/painting/DrawLooperLayerInfo.dart ('k') | sky/examples/raw/painting.sky » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/painting/DrawLooperLayerInfo.idl
diff --git a/sky/engine/core/painting/DrawLooperLayerInfo.idl b/sky/engine/core/painting/DrawLooperLayerInfo.idl
index 75614b61b2debcdaed6bc784ba09a990c8164fcd..5fed53d5c75a23bc8e64ae5c7ac69f53568ff972 100644
--- a/sky/engine/core/painting/DrawLooperLayerInfo.idl
+++ b/sky/engine/core/painting/DrawLooperLayerInfo.idl
@@ -5,23 +5,9 @@
[
Constructor(),
] interface DrawLooperLayerInfo {
- // Bits specifies which aspects of the layer's paint should replace the
- // corresponding aspects on the draw's paint.
- // ENTIRE_PAINT_BITS means use the layer's paint completely.
- // 0 means ignore the layer's paint... except for colorMode, which is
- // always applied.
- // TODO(mpcomplete): maybe these should each be functions (e.g. useStyle()).
- // TODO(mpcomplete): the IDL compiler doesn't use these for anything?
- // TODO(mpcomplete): dart style says to name these like 'styleBit'.
- const unsigned long STYLE_BIT = 0x1;
- const unsigned long TEXT_SKEWX_BIT = 0x2;
- const unsigned long PATH_EFFECT_BIT = 0x4;
- const unsigned long MASK_FILTER_BIT = 0x8;
- const unsigned long SHADER_BIT = 0x10;
- const unsigned long COLOR_FILTER_BIT = 0x20;
- const unsigned long XFERMODE_BIT = 0x40;
- const unsigned long ENTIRE_PAINT_BITS = -1;
-
+ // Specifies which aspects of the layer's paint should replace the
+ // corresponding aspects on the draw's paint. Use PaintBits, defined in
+ // DrawLooperLayerInfo.dart.
void setPaintBits(unsigned long bits);
void setColorMode(TransferMode mode);
// TODO(eseidel): Offset should be a Size not a Point.
« no previous file with comments | « sky/engine/core/painting/DrawLooperLayerInfo.dart ('k') | sky/examples/raw/painting.sky » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698