Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1175403002: Expose and use constants for DrawLooperLayerInfo.setPaintBits to dart. (Closed)

Created:
5 years, 6 months ago by Matt Perry
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Expose and use constants for DrawLooperLayerInfo.setPaintBits to dart. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d13dc06c2bcb0b07809c4843e46bb4c897767e40

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -21 lines) Patch
M sky/engine/core/core.gni View 1 chunk +1 line, -0 lines 0 comments Download
A sky/engine/core/painting/DrawLooperLayerInfo.dart View 1 chunk +23 lines, -0 lines 0 comments Download
M sky/engine/core/painting/DrawLooperLayerInfo.idl View 1 chunk +3 lines, -17 lines 0 comments Download
M sky/examples/raw/painting.sky View 2 chunks +5 lines, -2 lines 0 comments Download
M sky/examples/raw/shadow.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/painting/shadows.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Matt Perry
5 years, 6 months ago (2015-06-11 19:00:08 UTC) #2
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-11 19:33:52 UTC) #3
Matt Perry
5 years, 6 months ago (2015-06-11 19:41:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d13dc06c2bcb0b07809c4843e46bb4c897767e40 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698