Chromium Code Reviews
|
|
|
Created:
4 years, 10 months ago by Nate Chapin Modified:
4 years, 10 months ago CC:
blink-reviews, gavinp+loader_chromium.org, tyoshino+watch_chromium.org Base URL:
svn://svn.chromium.org/blink/trunk Target Ref:
refs/heads/master Project:
blink Visibility:
Public. |
DescriptionAdd the requested url to requestResource trace event
BUG=497440
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197498
Patch Set 1 #Patch Set 2 : rebase #Messages
Total messages: 26 (11 generated)
japhet@chromium.org changed reviewers: + paulirish@chromium.org
nice! thank you. lgtm
The CQ bit was checked by japhet@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175383005/1
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
On 2015/06/17 21:11:03, commit-bot: I haz the power wrote: > No LGTM from a valid reviewer yet. Only full committers are accepted. > Even if an LGTM may have been provided, it was from a non-committer, > _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files. rslgtm
The CQ bit was checked by japhet@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175383005/1
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
On 2015/06/17 21:14:58, Yoav Weiss wrote: > On 2015/06/17 21:11:03, commit-bot: I haz the power wrote: > > No LGTM from a valid reviewer yet. Only full committers are accepted. > > Even if an LGTM may have been provided, it was from a non-committer, > > _not_ a full super star committer. > > See http://www.chromium.org/getting-involved/become-a-committer > > Note that this has nothing to do with OWNERS files. > > rslgtm I think there needs to be a space between "s" and "l" for that to be valid?
On 2015/06/17 21:43:54, Nate Chapin wrote: > On 2015/06/17 21:14:58, Yoav Weiss wrote: > > On 2015/06/17 21:11:03, commit-bot: I haz the power wrote: > > > No LGTM from a valid reviewer yet. Only full committers are accepted. > > > Even if an LGTM may have been provided, it was from a non-committer, > > > _not_ a full super star committer. > > > See http://www.chromium.org/getting-involved/become-a-committer > > > Note that this has nothing to do with OWNERS files. > > > > rslgtm > > I think there needs to be a space between "s" and "l" for that to be valid? RS LGTM !!!
The CQ bit was checked by japhet@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175383005/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...) mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59551)
The CQ bit was checked by japhet@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from paulirish@chromium.org, yoav@yoav.ws Link to the patchset: https://codereview.chromium.org/1175383005/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175383005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/67335)
The CQ bit was checked by japhet@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175383005/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=197498 |
