Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1175373002: Add MODULES_EXPORT to SyncEvent (Closed)

Created:
5 years, 6 months ago by hans
Modified:
5 years, 6 months ago
Reviewers:
Nico, tasak
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add MODULES_EXPORT to SyncEvent To fix link error when building core and modules separately. BUG=358074, 492283 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196976

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/modules/background_sync/SyncEvent.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
hans
ptal
5 years, 6 months ago (2015-06-11 18:28:32 UTC) #2
Nico
lgtm
5 years, 6 months ago (2015-06-11 18:29:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175373002/1
5 years, 6 months ago (2015-06-11 18:31:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_blink_compile_dbg on tryserver.blink (JOB_TIMED_OUT, no build URL)
5 years, 6 months ago (2015-06-11 20:32:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175373002/1
5 years, 6 months ago (2015-06-11 20:42:11 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 21:29:12 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196976

Powered by Google App Engine
This is Rietveld 408576698