Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1793)

Unified Diff: Source/web/WebSharedWorkerImpl.cpp

Issue 1175323002: Rename WebSharedWorkerImpl::stopWorkerThread() to terminateWorkerThread() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: (rebase) Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebSharedWorkerImpl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebSharedWorkerImpl.cpp
diff --git a/Source/web/WebSharedWorkerImpl.cpp b/Source/web/WebSharedWorkerImpl.cpp
index df9c5ad7a277300a7f7f05c02dc52ec6e6a82c76..06f40e72bd502bafeb6d662738d9d8601b679382 100644
--- a/Source/web/WebSharedWorkerImpl.cpp
+++ b/Source/web/WebSharedWorkerImpl.cpp
@@ -185,8 +185,7 @@ WebSharedWorkerImpl::~WebSharedWorkerImpl()
m_loaderProxy->detachProvider(this);
}
-// TODO(toyoshim): Rename to terminateWorkerThread().
-void WebSharedWorkerImpl::stopWorkerThread()
+void WebSharedWorkerImpl::terminateWorkerThread()
{
if (m_askedToTerminate)
return;
@@ -328,7 +327,7 @@ void WebSharedWorkerImpl::workerGlobalScopeClosedOnMainThread()
if (client())
client()->workerContextClosed();
- stopWorkerThread();
+ terminateWorkerThread();
}
void WebSharedWorkerImpl::workerGlobalScopeStarted(WorkerGlobalScope*)
@@ -434,7 +433,7 @@ void WebSharedWorkerImpl::onScriptLoaderFinished()
void WebSharedWorkerImpl::terminateWorkerContext()
{
- stopWorkerThread();
+ terminateWorkerThread();
}
void WebSharedWorkerImpl::clientDestroyed()
« no previous file with comments | « Source/web/WebSharedWorkerImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698