Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(23)

Issue 1175323002: Rename WebSharedWorkerImpl::stopWorkerThread() to terminateWorkerThread() (Closed)

Created:
4 years, 10 months ago by Takashi Toyoshima
Modified:
4 years, 10 months ago
Reviewers:
tkent, kinuko
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Rename WebSharedWorkerImpl::stopWorkerThread() to terminateWorkerThread() To make interface names consistent with other Worker related classes, rename stopWorkerThread() to terminateWorkerThread(). BUG=487050 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196950

Patch Set 1 #

Patch Set 2 : (rebase) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M Source/web/WebSharedWorkerImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSharedWorkerImpl.cpp View 1 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175323002/1
4 years, 10 months ago (2015-06-11 11:56:56 UTC) #2
Takashi Toyoshima
This is one of two TODO from https://codereview.chromium.org/1175233004/. tkent@: PTAL. kinuko@: FYI.
4 years, 10 months ago (2015-06-11 11:58:49 UTC) #5
tkent
lgtm
4 years, 10 months ago (2015-06-11 12:22:29 UTC) #6
kinuko
lgtm
4 years, 10 months ago (2015-06-11 12:48:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175323002/20001
4 years, 10 months ago (2015-06-11 12:57:04 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2015-06-11 14:18:12 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196950

Powered by Google App Engine
This is Rietveld 408576698