Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(18)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1175313002: Add ASSERT(isMainThread()) to WorkerThread::start() and ::terminate() (Closed)

Created:
4 years, 10 months ago by Takashi Toyoshima
Modified:
4 years, 10 months ago
Reviewers:
kinuko
CC:
blink-reviews, kinuko+worker_chromium.org, horo+watch_chromium.org, falken
Project:
blink
Visibility:
Public.

Description

Add ASSERT(isMainThread()) to WorkerThread::start() and ::terminate() BUG=487050 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197172

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : move into terminateInternal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M Source/core/workers/WorkerThread.cpp View 1 2 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Takashi Toyoshima
Could we have ASSERTs so that it should be enforced as the header comments say?
4 years, 10 months ago (2015-06-11 13:01:35 UTC) #2
kinuko
Can you run try jobs? https://codereview.chromium.org/1175313002/diff/20001/Source/core/workers/WorkerThread.cpp File Source/core/workers/WorkerThread.cpp (right): https://codereview.chromium.org/1175313002/diff/20001/Source/core/workers/WorkerThread.cpp#newcode292 Source/core/workers/WorkerThread.cpp:292: ASSERT(isMainThread()); Should this rather ...
4 years, 10 months ago (2015-06-12 05:48:03 UTC) #3
Takashi Toyoshima
https://codereview.chromium.org/1175313002/diff/20001/Source/core/workers/WorkerThread.cpp File Source/core/workers/WorkerThread.cpp (right): https://codereview.chromium.org/1175313002/diff/20001/Source/core/workers/WorkerThread.cpp#newcode292 Source/core/workers/WorkerThread.cpp:292: ASSERT(isMainThread()); On 2015/06/12 05:48:03, kinuko wrote: > Should this ...
4 years, 10 months ago (2015-06-15 05:01:03 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175313002/40001
4 years, 10 months ago (2015-06-16 04:15:49 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2015-06-16 06:15:57 UTC) #8
Takashi Toyoshima
try and CQ dryrun passed. PTAL.
4 years, 10 months ago (2015-06-16 09:33:19 UTC) #9
kinuko
lgtm
4 years, 10 months ago (2015-06-16 14:41:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175313002/40001
4 years, 10 months ago (2015-06-16 14:58:16 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2015-06-16 15:03:25 UTC) #13
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197172

Powered by Google App Engine
This is Rietveld 408576698